Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32-hal-i2c.c possible semaphore deadlock #10304

Closed
1 task done
vvb333007 opened this issue Sep 6, 2024 · 1 comment · Fixed by #10313
Closed
1 task done

esp32-hal-i2c.c possible semaphore deadlock #10304

vvb333007 opened this issue Sep 6, 2024 · 1 comment · Fixed by #10313
Labels
Status: In Progress ⚠️ Issue is in progress Type: Bug 🐛 All bugs

Comments

@vvb333007
Copy link

Board

ESP32-WROOM-32D

Device Description

Generic ESP32 breakout board

Hardware Configuration

no connections

Version

v3.0.4

IDE Name

Arduino IDE

Operating System

Windows10

Flash frequency

80Mhz

PSRAM enabled

no

Upload speed

921600

Description

Code in esp32-hal-i2c.c has an issue: upon some circumstancies it is possible that function i2cInit() returns without releasing a locking semaphore. Plus to that a boolean is returned instead ot sep_err_t. See attached screenshot: problematic code was commented out and a solution proposed.
image

Sketch

issue is on the screenshot. no sketch needed.

Debug Message

There are no messages

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@vvb333007 vvb333007 added the Status: Awaiting triage Issue is waiting for triage label Sep 6, 2024
@me-no-dev me-no-dev mentioned this issue Sep 9, 2024
Merged
@me-no-dev
Copy link
Member

Hi @vvb333007 :) it's came out to be a bit more complicated than that. Please see and try this: #10313

@me-no-dev me-no-dev added Type: Bug 🐛 All bugs and removed Status: Awaiting triage Issue is waiting for triage labels Sep 9, 2024
@VojtechBartoska VojtechBartoska added the Status: In Progress ⚠️ Issue is in progress label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress ⚠️ Issue is in progress Type: Bug 🐛 All bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i2c): Ensure that semaphore is properly given if init fails espressif/arduino-esp32
3 participants
@me-no-dev @VojtechBartoska @vvb333007