Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint-community/eslint-plugin-eslint-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.5.0
Choose a base ref
...
head repository: eslint-community/eslint-plugin-eslint-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.0
Choose a head ref
  • 15 commits
  • 106 files changed
  • 4 contributors

Commits on Jun 19, 2025

  1. ci: add node v24 to test matrix (#522)

    * ci: add node v24 to test matrix
    
    This change adds node v24 to the matrix for ci testing
    
    * ci: add node v24 to test matrix
    
    This change adds node v24 to the matrix for ci testing
    michaelfaith authored Jun 19, 2025
    Configuration menu
    Copy the full SHA
    5fce6f8 View commit details
    Browse the repository at this point in the history
  2. chore: update typescript deps (#523)

    * chore: update typescript deps
    
    * try to fix test
    bmish authored Jun 19, 2025
    Configuration menu
    Copy the full SHA
    41a9166 View commit details
    Browse the repository at this point in the history
  3. test: change test runner to vitest (#525)

    * test: change test runner to vitest
    
    This change moves the test runner from `mocha` + `nyc` to `vitest`.
    
    In order to import `vitest` the tests had to be in esm, so I checked out everything under the `tests` folder from #516 (leaving the source as it was).
    
    I also moved the `eslint-rule-tester` out of the `tests/lib` folder and into its own `utils` folder.  That way vitest didn't treat it as a test.
    
    Note: rather than using `vitest`'s preferred `v8` coverage reporter, I used the `istanbul` one, to ensure the coverages between old and new were the same.  I did notice that when I tried the `v8` coverage reporter, the coverage numbers were much less.  Something to consider as a follow-up change.  The v8 reporter *should* be more accurate, so the coverage may not be as high as it seems.  I'd recommend moving up to the `v8` reporter after the esm branch lands.
    
    * test: update fixtures tsconfig to use wildcard
    
    * build: remove `globals` and packageManager config
    michaelfaith authored Jun 19, 2025
    Configuration menu
    Copy the full SHA
    c316040 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2025

  1. feat!: move to ESM only (#516)

    * feat: move to ESM only
    
    * chore: move to c8 for esm support
    
    * chore: revert some mistaken replaces
    
    * fix: add no-meta-replaced-by to index
    
    * mocha timeout from 2000 to 3000 for slow no-property-in-node test
    
    * git ignore coverage/
    
    * Revert "mocha timeout from 2000 to 3000 for slow no-property-in-node test"
    
    This reverts commit 8a8fb60.
    
    * chore: remove duplicate gitignore
    
    * chore: revert comment change
    
    ---------
    
    Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
    43081j and bmish authored Jun 20, 2025
    Configuration menu
    Copy the full SHA
    9cd5af8 View commit details
    Browse the repository at this point in the history
  2. build: fix eslint.config following esm update (#527)

    This change updates the eslint config to use `sourceType: 'module'`, and swaps n's `flat/mixed-esm-and-cjs` config for `flat/recommended` which will use the module type from the nearest `package.json`.
    michaelfaith authored Jun 20, 2025
    Configuration menu
    Copy the full SHA
    0b708d7 View commit details
    Browse the repository at this point in the history
  3. feat!: remove eslint v8 / eslintrc support and remove flat/ prefix …

    …from configs (#528)
    
    * feat!: remove eslint v8 support
    
    This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0.  I've also removed the deprecated `/configs` entry point.
    
    * use test setup file
    
    * docs: update examples
    
    * build: disable n/no-missing-import for md files
    
    * build: disable n/no-missing-import for md files
    
    ---------
    
    Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
    michaelfaith and bmish authored Jun 20, 2025
    Configuration menu
    Copy the full SHA
    03cf3d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2025

  1. feat!: require Node 20, 22, 24+ (#529)

    * feat!: remove support for EoL Node versions
    
    This change removes support for Node v18, 21, and 23.  Supported versions are now `"^20.9.0 || ^22.11.0 || >=24.0.0"`
    
    * Update package.json
    
    updated to newer node versions
    
    Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
    michaelfaith and bmish authored Jun 21, 2025
    Configuration menu
    Copy the full SHA
    b2994c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2025

  1. Configuration menu
    Copy the full SHA
    f8775e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. refactor: remove context compat functions (#532)

    This change is in support of the larger migration to TypeScript., and a followup to the removal of support for ESLint v8.  The context compatibility functions in the `utils` module were no longer necessary.  I originally did this in the TypeScript branch, but that PR's going to be large enough.  So, I'm trying to peel off smaller independent changes I can land separately first.
    michaelfaith authored Jul 23, 2025
    Configuration menu
    Copy the full SHA
    f834dc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2025

  1. build: convert eslint-remote-tester config to typescript (#533)

    * git mv
    
    * build: convert eslint-remote-tester config to typescript
    
    Supporting the larger typescript migration, this change migrates the config for `eslint-remote-tester` to typescript, which will be necessary to run our plugin from source, once it's typescript.
    
    * Bump version of eslint-remote-tester to pick up bug fix
    michaelfaith authored Jul 25, 2025
    Configuration menu
    Copy the full SHA
    96be606 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2025

  1. feat: migrate package to TypeScript and publish types (#534)

    * change test-setup to ts
    
    * add build config
    
    * add types packages
    
    * rename files to ts
    
    * migrate fixer-return
    
    migrate fixer-return
    
    migrate fixer-return
    
    * migrate consistent-output
    
    migrate consistent-output
    
    * migrate meta-property-ordering
    
    * migrate no-deprecated-context-methods
    
    * migrate no-deprecated-report-api
    
    * migrate no-identical-tests
    
    * migrate no-meta-replaced-by
    
    * migrate no-meta-schema-default
    
    * migrate no-missing-message-ids
    
    * migrate no-missing-placeholders
    
    * migrate no-only-tests
    
    * migrate no-property-in-node
    
    * migrate no-unused-message-ids
    
    * migrate no-unused-placeholders
    
    * migrate no-useless-token-range
    
    * migrate prefer-message-ids
    
    * migrate prefer-object-rule
    
    * migrate prefer-output-null
    
    * migrate prefer-placeholders
    
    * migrate prefer-replace-text
    
    * migrate report-message-format
    
    * migrate require-meta-default-options
    
    * migrate require-meta-docs-description
    
    * migrate prefer-replace-text
    
    * migrate require-meta-docs-recommended
    
    * migrate require-meta-docs-url
    
    * migrate require-meta-fixable
    
    * migrate require-meta-has-suggestions
    
    * migrate require-meta-schema-description
    
    * migrate require-meta-schema
    
    * migrate require-meta-type
    
    * migrate test-case-property-ordering
    
    * migrate test-case-shorthand-strings
    
    * migrate plugin (index)
    
    * migrate indext.ts test
    
    * git mv all rule tests
    
    * fix type issues in no-meta-replaced-by test
    
    * fix type issues with no-missing-placeholders tests
    
    * fix type issues with no-unused-placeholders tests
    
    * fix type issues with no-useless-token-range tests
    
    * fix type issues with report-message-format tests
    
    * remove invalid case from valid array
    
    * fix type issues with test-case-shorthand-strings
    
    * fix type issues in rule-setup tests
    
    * Add explicit extensions to imports without them
    
    * fix type issues in utils tests
    
    * fix merge issue
    
    * adjust import order
    
    * fix plugin type
    
    * fix utils tests
    
    * switch to tsup for build
    
    * Change import of `package.json` to require, for backwards compatibility
    
    * fix utils tests
    
    * update rule-setup tests
    
    * add build to publish workflow
    
    * add slashes to .gitignore
    
    * remove jsdoc type annotation from `fixer-return`
    
    * remove unnecessary param from `no-indentical-tests`
    
    * add early return in `no-missing-placeholders`
    
    * removed assert in `no-only-tests`
    
    * remove empty param annotation from `no-property-in-node`
    
    * remove casting from no-unused-message-ids
    
    * add back valid test case to require-meta-type
    
    * add explanatory comment to estree.d.ts
    
    * remove type annotation from comment in test-case-shorthand-string
    
    * removed casting from no-meta-schema-default
    
    * remove casts from no-useless-token-range
    
    * remove cast from report-message-format
    
    * remove cast from require-meta-default-options
    
    * remove cast from require-meta-docs-url
    
    * remove casts from require-meta-fixables
    
    * remove cast from require-meta-type
    
    * Adjust PartialRuleInfo types
    
    * addressed feedback in utils
    
    * ci: add typecheck step to CI workflow
    
    * removed unneeded ts-expect-error from eslint.config.ts
    
    * Address feedback in utils
    
    * remove non-null assertion from require-meta-docs-recommended
    michaelfaith authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    95b859a View commit details
    Browse the repository at this point in the history
  2. feat!: enable no-meta-replaced-by, no-meta-schema-default, `requi…

    …re-meta-default-options`, `require-meta-schema-description` as `recommended` rules (#530)
    
    feat!: enable no-meta-replaced-by, no-meta-schema-default, require-meta-default-options, require-meta-schema-description as recommended rules
    bmish authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    b353bd1 View commit details
    Browse the repository at this point in the history
  3. chore: switch to TypeScript for .eslint-doc-generatorrc.ts (#536)

    chore: switch to TypeScript for .eslint-doc-generatorrc.ts
    bmish authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    aa3a4d9 View commit details
    Browse the repository at this point in the history
  4. build: update typescript to 5.9 (#535)

    * build: update typescript
    
    This change updates `typescript` to 5.9
    
    * caret
    
    ---------
    
    Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
    michaelfaith and bmish authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    6b1347d View commit details
    Browse the repository at this point in the history
  5. chore(main): release 7.0.0 (#526)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Aug 4, 2025
    Configuration menu
    Copy the full SHA
    a923ff4 View commit details
    Browse the repository at this point in the history
Loading