Skip to content

Commit 56c5055

Browse files
committed
reduce -s linker warning to debug
1 parent 12706b0 commit 56c5055

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

emcc

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def is_minus_s_for_emcc(newargs, i):
167167
if i+1 < len(newargs) and '=' in newargs[i+1] and not newargs[i+1].startswith('-'): # -s OPT=VALUE is for us, -s by itself is a linker option
168168
return True
169169
else:
170-
logging.warning('treating -s as linker option and not as -s OPT=VALUE for js compilation')
170+
logging.debug('treating -s as linker option and not as -s OPT=VALUE for js compilation')
171171
return False
172172

173173
# If this is a configure-type thing, do not compile to JavaScript, instead use clang

tests/test_other.py

-1
Original file line numberDiff line numberDiff line change
@@ -2073,7 +2073,6 @@ def test_link_s(self):
20732073
Popen([PYTHON, EMCC, os.path.join(self.get_dir(), 'supp.cpp'), '-o', 'supp.o']).communicate()
20742074

20752075
output = Popen([PYTHON, EMCC, os.path.join(self.get_dir(), 'main.o'), '-s', os.path.join(self.get_dir(), 'supp.o'), '-s', 'SAFE_HEAP=1'], stderr=PIPE).communicate()
2076-
self.assertContained('treating -s as linker option', output[1])
20772076
output = run_js('a.out.js')
20782077
assert 'yello' in output, 'code works'
20792078
code = open('a.out.js').read()

0 commit comments

Comments
 (0)