Skip to content

Commit 07cf113

Browse files
committed
Revise the previous fix to apply to browser.test_sdl2_mouse_offsets as well.
1 parent 562fabb commit 07cf113

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

tests/sdl2_mouse.c

+13
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,13 @@ void one() {
1616
SDL_MouseMotionEvent *m = (SDL_MouseMotionEvent*)&event;
1717
assert(m->state == 0);
1818
printf("motion : %d,%d %d,%d\n", m->x, m->y, m->xrel, m->yrel);
19+
#ifdef TEST_SDL_MOUSE_OFFSETS
20+
assert(eq(m->x, 5) && eq(m->y, 15) && eq(m->xrel, 5) && eq(m->yrel, 15)
21+
|| eq(m->x, 25) && eq(m->y, 65) && eq(m->xrel, 20) && eq(m->yrel, 50));
22+
#else
1923
assert(eq(m->x, 10) && eq(m->y, 20) && eq(m->xrel, 10) && eq(m->yrel, 20)
2024
|| eq(m->x, 30) && eq(m->y, 70) && eq(m->xrel, 20) && eq(m->yrel, 50));
25+
#endif
2126
break;
2227
}
2328
case SDL_MOUSEBUTTONDOWN: {
@@ -27,13 +32,21 @@ void one() {
2732
emscripten_run_script("throw 'done'");
2833
}
2934
printf("button down : %d,%d %d,%d\n", m->button, m->state, m->x, m->y);
35+
#ifdef TEST_SDL_MOUSE_OFFSETS
36+
assert(eq(m->button, 1) && eq(m->state, 1) && eq(m->x, 5) && eq(m->y, 15));
37+
#else
3038
assert(eq(m->button, 1) && eq(m->state, 1) && eq(m->x, 10) && eq(m->y, 20));
39+
#endif
3140
break;
3241
}
3342
case SDL_MOUSEBUTTONUP: {
3443
SDL_MouseButtonEvent *m = (SDL_MouseButtonEvent*)&event;
3544
printf("button up : %d,%d %d,%d\n", m->button, m->state, m->x, m->y);
45+
#ifdef TEST_SDL_MOUSE_OFFSETS
46+
assert(eq(m->button, 1) && eq(m->state, 0) && eq(m->x, 5) && eq(m->y, 15));
47+
#else
3648
assert(eq(m->button, 1) && eq(m->state, 0) && eq(m->x, 10) && eq(m->y, 20));
49+
#endif
3750
// Remove another click we want to ignore
3851
assert(SDL_PeepEvents(&event, 1, SDL_GETEVENT, SDL_MOUSEBUTTONDOWN, SDL_MOUSEBUTTONDOWN) == 1);
3952
assert(SDL_PeepEvents(&event, 1, SDL_GETEVENT, SDL_MOUSEBUTTONUP, SDL_MOUSEBUTTONUP) == 1);

tests/test_browser.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2560,8 +2560,8 @@ def test_sdl2_mouse_offsets(self):
25602560
''')
25612561
open(os.path.join(self.get_dir(), 'sdl2_mouse.c'), 'w').write(self.with_report_result(open(path_from_root('tests', 'sdl2_mouse.c')).read()))
25622562

2563-
Popen([PYTHON, EMCC, os.path.join(self.get_dir(), 'sdl2_mouse.c'), '-O2', '--minify', '0', '-o', 'sdl2_mouse.js', '--pre-js', 'pre.js', '-s', 'USE_SDL=2']).communicate()
2564-
self.run_browser('page.html', '', '/report_result?572')
2563+
Popen([PYTHON, EMCC, os.path.join(self.get_dir(), 'sdl2_mouse.c'), '-DTEST_SDL_MOUSE_OFFSETS=1', '-O2', '--minify', '0', '-o', 'sdl2_mouse.js', '--pre-js', 'pre.js', '-s', 'USE_SDL=2']).communicate()
2564+
self.run_browser('page.html', '', '/report_result?1')
25652565

25662566
def test_sdl2glshader(self):
25672567
self.btest('sdl2glshader.c', reference='sdlglshader.png', args=['-s', 'USE_SDL=2', '-O2', '--closure', '1', '-s', 'LEGACY_GL_EMULATION=1'])

0 commit comments

Comments
 (0)