Remove redundant dead inst elimination

jfbastien · jfbastien · commit 2853e8fd2641 · 2015-03-30T15:33:17.000-07:00
Post-opt passes were running dead inst elimination as well as dead code elimination, which is strictly superior to dead inst elimination. R=dschuff@chromium.org BUG= none TEST= make check Review URL: https://codereview.chromium.org/1045043003
diff --git a/lib/Transforms/NaCl/PNaClABISimplify.cpp b/lib/Transforms/NaCl/PNaClABISimplify.cpp
@@ -173,8 +173,6 @@ void llvm::PNaClABISimplifyAddPostOptPasses(PassManagerBase &PM) {
   // ReplacePtrsWithInts leaves the lifetime.start/end intrinsics.
   PM.add(createStripDeadPrototypesPass());
 
-  // Eliminate simple dead code that the post-opt passes could have
-  // created.
-  PM.add(createDeadInstEliminationPass());
+  // Eliminate simple dead code that the post-opt passes could have created.
   PM.add(createDeadCodeEliminationPass());
 }

Original file line number	Diff line number	Diff line change
`@@ -173,8 +173,6 @@ void llvm::PNaClABISimplifyAddPostOptPasses(PassManagerBase &PM) {`
`173`	`173`	`// ReplacePtrsWithInts leaves the lifetime.start/end intrinsics.`
`174`	`174`	`PM.add(createStripDeadPrototypesPass());`
`175`	`175`
`176`		`- // Eliminate simple dead code that the post-opt passes could have`
`177`		`- // created.`
`178`		`- PM.add(createDeadInstEliminationPass());`
	`176`	`+ // Eliminate simple dead code that the post-opt passes could have created.`
`179`	`177`	`PM.add(createDeadCodeEliminationPass());`
`180`	`178`	`}`