Object initializers indent incorrectly when type initialized is generic

[josteink]

The following indents fine:

var items = new ArrayList
{
    // items
};

The following does not:

var items = new List<string>
{
    // items
};

The reason for this is outlined in this issue here: #72 (comment)

The culprit for the code that's failing to indent properly in the test file seems to be https://github.com/josteink/csharp-mode/blob/master/csharp-mode.el#L485, which fails to recognize the presence of a vsemi when the object being initialized is a generic. This is a complicated issue to resolve because we would have to somehow recursively match the generic type parameter, which could itself be a generic.

[josteink]

Not reopening yet... but the following case fails, for reasons outlined in comment above:

            var map = new Dicrionary<string,Func<int, bool>>
                {
                    { "IsZero", (int i) => i == 0 }
                };

[cg505]

Types can have dots, so I think this is still a little bit broken.

[cg505]

I think this is fodder for another issue, but in a similar issue, fontification breaks in many cases where type parameters have dots.

[josteink]

Sounds like something we’ve systematically failed to address.

I’m on vacation right now so I won’t do anything with this issue for the next few weeks.

Feel free to take a look yourself and issue a PR!

[josteink]

I think this is fodder for another issue, but in a similar issue, fontification breaks in many cases where type parameters have dots.

I just did some basic looking around for this, but didn't find any immediately obvious cases. Do you have any examples?

[cg505]

This is what I mean:

            var test = new Generic<Namespace.Class>
                {
                    Boolean = true
                };

I think there may be a few other places in the mode where a regex intends to match a type but does not allow for qualified types.

My bad. You were asking about fontification. I don't know how to read.

[cg505]

Compare these two declarations:

ClassName<ClassName> foo;
ClassName<Namespace.ClassName> foo;

foo is correctly fontified in the first, but not the second.