imenu: Fix indexing of delegates.

With or without namespace. Add tests.

This closes #80.

Author: josteink

csharp-mode-tests.el

@@ -234,6 +234,15 @@
   "(method) AbstractMethod("
   "(method) UnsafeCopy(")
 
+(def-imenutest imenu-parsing-supports-delegates
+  "./test-files/imenu-delegate-test.cs"
+  "delegate PromptCallback"
+  "delegate PromptStateCallback"
+  "delegate PromptStateCallback<T>"
+  "delegate Foobar.TargetCallback"
+  "delegate Foobar.TargetStateCallback"
+  "delegate Foobar.TargetStateCallback<T>")
+
 (ert-deftest imenu-indexing-resolves-correct-container ()
   (let* ((testcase-no-namespace '( ("class Global" . 10)
                                    (("namespace_a" . 20) ("namespace_b" . 30))

csharp-mode.el

@@ -1893,9 +1893,9 @@ to the beginning of the prior namespace.
                         return-type space
                         "\\("
                         generic-identifier
+                        "\\)"
                         optional-space
                         parameter-list
-                        "\\)"
                         ;; optional // or /* comment at end
                         optional-space
                         ";") 1)
@@ -2113,10 +2113,19 @@ to the beginning of the prior namespace.
     ;; `helm-imenu', but there's nothing we can do about that.
     ;; The alternative is making it a menu with -1- submenu which
     ;; says "( top )" but that will be very clicky...
+
+    ;; before adding delegates, we need to pad the entry so that it
+    ;; matches the "<type> <name>" signature used by all the other
+    ;; imenu entries
+    (let ((delegates (cdr (assoc "delegate" index))))
+      (dolist (delegate delegates)
+        (setf (car delegate) (concat "delegate " (car delegate)))))
+
     (dolist (type '("enum" "delegate"))
       (dolist (item (cdr (assoc type index)))
         (let ((item-name (csharp--imenu-get-class-name item namespaces)))
-          (setq result (cons (cons item-name (cdr item)) result)))))
+          (setq result (cons (cons item-name (cdr item))
+                             result)))))
 
     ;; sort individual sub-lists
     (dolist (item result)

test-files/imenu-delegate-test.cs

@@ -1,12 +1,12 @@
 using System;
 
-namespace Boo
+public delegate void PromptCallback( Mobile from, string text );
+public delegate void PromptStateCallback( Mobile from, string text, object state );
+public delegate void PromptStateCallback<T>( Mobile from, string text, T state );
+
+namespace Foobar
 {
     public delegate void TargetCallback( Mobile from, object targeted );
     public delegate void TargetStateCallback( Mobile from, object targeted, object state );
     public delegate void TargetStateCallback<T>( Mobile from, object targeted, T state );
 }
-
-public delegate void PromptCallback( Mobile from, string text );
-public delegate void PromptStateCallback( Mobile from, string text, object state );
-public delegate void PromptStateCallback<T>( Mobile from, string text, T state );