Skip to content

Commit de6c68b

Browse files
Merge pull request #489 from elixir-editors/fix/duplicated_tests_not_running_on_29
fix(tests): remove duplicated tests
2 parents 6f61e04 + 5eaaa67 commit de6c68b

File tree

3 files changed

+12
-83
lines changed

3 files changed

+12
-83
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ on:
1010

1111
jobs:
1212
test:
13-
name: mix test (Emacs ${{matrix.emacs_version}} | Elixir ${{matrix.elixir}} | Erlang/OTP ${{matrix.otp}})
13+
name: test (Emacs ${{matrix.emacs_version}} | Elixir ${{matrix.elixir}} | Erlang/OTP ${{matrix.otp}})
1414
runs-on: ubuntu-latest
1515
strategy:
1616
matrix:
17-
emacs_version: ['27.1', '26.3', '25.2']
18-
otp: ['22.3', '23.2', '24.2']
19-
elixir: ['1.9.4', '1.11.4', '1.13.1']
17+
emacs_version: ['27.2', '26.3', '25.3', 'snapshot']
18+
otp: ['23.3']
19+
elixir: ['1.9.4', '1.11.4', '1.13.3']
2020

2121
steps:
2222
- name: Setup Emacs

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,11 @@ Alternatively, if you want to use `ruby-end-mode`, you can add the following to
133133
(ruby-end-mode +1)))
134134
```
135135

136+
## Notes
137+
138+
This package is tested only with a single version of OTP and 3 versions of Elixir. Please, always report versions
139+
(Emacs, Elixir and Erlang/OTP) when raising issues.
140+
136141
## Elixir Tooling Integration
137142

138143
If you looking for elixir tooling integration for Emacs, check: [alchemist.el](https://github.com/tonini/alchemist.el)

tests/elixir-mode-helper-test.el

Lines changed: 3 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ defmodule Module.Name do
1717
1818
end")
1919
(goto-line 7)
20-
(elixir-smie--heredoc-at-current-point-p)))
20+
(elixir-smie--heredoc-at-current-point-p)
21+
))
2122
(should (not (with-temp-buffer
2223
(elixir-mode)
2324
(insert "
@@ -44,8 +45,7 @@ defmodule Module.Name do
4445
end
4546
end")
4647
(goto-line 4)
47-
(elixir-smie--previous-line-indentation))))
48-
)
48+
(elixir-smie--previous-line-indentation)))))
4949

5050

5151
(ert-deftest check-if-previous-line-blank ()
@@ -73,82 +73,6 @@ end")
7373
(goto-line 4)
7474
(elixir-smie--previous-line-empty-p))))
7575

76-
77-
;;; elixir-mode-helper-test.el --- Tests for helper functions
78-
79-
;;; Code:
80-
81-
(ert-deftest check-if-currently-inside-heredoc ()
82-
(should (with-temp-buffer
83-
(elixir-mode)
84-
(insert "
85-
defmodule Module.Name do
86-
87-
@moduledoc \"\"\"
88-
## Examples
89-
90-
....
91-
\"\"\"
92-
93-
end")
94-
(goto-line 7)
95-
(elixir-smie--heredoc-at-current-point-p)))
96-
(should (not (with-temp-buffer
97-
(elixir-mode)
98-
(insert "
99-
defmodule Module.Name do
100-
101-
@moduledoc \"\"\"
102-
## Examples
103-
104-
....
105-
\"\"\"
106-
107-
end")
108-
(goto-line 3)
109-
(elixir-smie--heredoc-at-current-point-p)))))
110-
111-
(ert-deftest get-previous-line-indentation ()
112-
(should (equal 2
113-
(with-temp-buffer
114-
(elixir-mode)
115-
(insert "
116-
defmodule Module.Name do
117-
def what do
118-
1 + 1
119-
end
120-
end")
121-
(goto-line 4)
122-
(elixir-smie--previous-line-indentation))))
123-
)
124-
125-
126-
(ert-deftest check-if-previous-line-blank ()
127-
(should (not (with-temp-buffer
128-
(elixir-mode)
129-
(insert "
130-
defmodule Module.Name do
131-
132-
def what do
133-
1 + 1
134-
end
135-
end")
136-
(goto-line 3)
137-
(elixir-smie--previous-line-empty-p))))
138-
(should (with-temp-buffer
139-
(elixir-mode)
140-
(insert "
141-
defmodule Module.Name do
142-
143-
144-
def what do
145-
1 + 1
146-
end
147-
end")
148-
(goto-line 4)
149-
(elixir-smie--previous-line-empty-p))))
150-
151-
15276
(ert-deftest test-current-line-contains-built-in-keyword ()
15377
(should (not (with-temp-buffer
15478
(elixir-mode)

0 commit comments

Comments
 (0)