Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] restore better syntax error messages #124145

Closed
drewdaemon opened this issue Mar 5, 2025 · 2 comments · Fixed by #124177
Closed

[ES|QL] restore better syntax error messages #124145

drewdaemon opened this issue Mar 5, 2025 · 2 comments · Fixed by #124177
Labels
:Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@drewdaemon
Copy link
Contributor

Description

21845ad resulted in some negative changes to our syntax error messages.

The top priority is row var = 1 not in

  • used to result in mismatched input '<EOF>' expecting '('
  • but now says mismatched input '<EOF>' expecting LP
Image

(the lexer lost the literal name for LP, so it just gives the symbolic name... this won't be obvious to a user).

Also, an incorrect command name generates an error with a missing element in the list

from index | project

  • used to result in mismatched input 'PROJECT' expecting {'dissect', 'drop', 'enrich', 'eval', 'grok', 'keep', 'limit', 'mv_expand', 'rename', 'sort', 'stats', 'where', 'lookup'}
  • but now says mismatched input 'PROJECT' expecting {, 'enrich', 'dissect', 'eval', 'grok', 'limit', 'sort', 'stats', 'where', 'lookup', 'mv_expand', 'drop', 'keep', 'rename'}

Could we restore the original behavior in these cases? Particularly, the parentheses.

@drewdaemon drewdaemon added :Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI needs:triage Requires assignment of a team area label labels Mar 5, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Mar 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants