Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for knn rescore vector #122723

Closed
carlosdelest opened this issue Feb 17, 2025 · 2 comments · Fixed by #122801
Closed

Increase test coverage for knn rescore vector #122723

carlosdelest opened this issue Feb 17, 2025 · 2 comments · Fixed by #122801
Labels
:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests

Comments

@carlosdelest
Copy link
Member

carlosdelest commented Feb 17, 2025 •
edited
Loading

#122653 fixed a scoring bug for knn rescore. This bug should have been caught earlier, as scores were not being sorted when retrieved from knn search.

The issue is fixed, but we need to add test coverage to ensure any scoring issue is detected in knn rescore.
@carlosdelest carlosdelest added :Search Relevance/Vectors Vector search >test Issues or PRs that are addressing/adding tests Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Feb 17, 2025
@carlosdelest carlosdelest mentioned this issue Feb 17, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@javanna
Copy link
Member

javanna commented Feb 17, 2025

Thanks for opening this. I think that testing against multiple segments, using indexRandom to index document may be what was missing to catch the problem.

@carlosdelest carlosdelest mentioned this issue Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rescore knn vector test coverage carlosdelest/elasticsearch
3 participants
@javanna @carlosdelest @elasticsearchmachine