Minor whitespace and styling fixes

Author: picandocodigo

Rakefile

@@ -75,12 +75,12 @@ end
 # subprojects.each { |project| $LOAD_PATH.unshift CURRENT_PATH.join(project, "lib").to_s }
 
 task :default do
-  system "rake --tasks"
+  system 'rake --tasks'
 end
 
 desc 'Display information about subprojects'
 task :subprojects do
-  puts '-'*80
+  puts '-' * 80
   SUBPROJECTS.each do |project|
     commit  = `git log --pretty=format:'%h %ar: %s' -1 #{project}`
     version =  Gem::Specification::load(CURRENT_PATH.join(project, "#{project}.gemspec").to_s).version.to_s
@@ -96,7 +96,7 @@ namespace :bundle do
   desc 'Run `bundle install` in all subprojects'
   task :install do
     SUBPROJECTS.each do |project|
-      puts '-'*80
+      puts '-' * 80
       sh "cd #{CURRENT_PATH.join(project)} && unset BUNDLE_GEMFILE && bundle install"
       puts
     end

elasticsearch/Rakefile

@@ -11,7 +11,6 @@ task :test    => 'test:unit'
 
 require 'rake/testtask'
 namespace :test do
-
   desc "Wait for Elasticsearch to be in a green state"
   task :wait_for_green do
     sh '../scripts/wait-cluster.sh'

rake_tasks/elasticsearch_tasks.rake

@@ -1,15 +1,14 @@
-ELASTICSEARCH_PATH = "#{CURRENT_PATH}/tmp/elasticsearch"
+ELASTICSEARCH_PATH = "#{CURRENT_PATH}/tmp/elasticsearch".freeze
 
-desc "Clone elasticsearch into the ./tmp directory"
+desc 'Clone elasticsearch into the ./tmp directory'
 task :setup do
   unless File.exist?('./tmp/elasticsearch')
-    sh "git clone https://github.com/elasticsearch/elasticsearch.git tmp/elasticsearch"
+    sh 'git clone https://github.com/elasticsearch/elasticsearch.git tmp/elasticsearch'
   end
 end
 
 namespace :elasticsearch do
-
-  desc "Wait for elasticsearch cluster to be in green state"
+  desc 'Wait for elasticsearch cluster to be in green state'
   task :wait_for_green do
     require 'elasticsearch'
 
@@ -21,10 +20,10 @@ namespace :elasticsearch do
           ready = true
           break
         end
-      rescue Elasticsearch::Transport::Transport::Errors::RequestTimeout => ex
-        puts "Couldn't confirm green status.\n#{ex.inspect}."
-      rescue Faraday::ConnectionFailed => ex
-        puts "Couldn't connect to Elasticsearch.\n#{ex.inspect}."
+      rescue Elasticsearch::Transport::Transport::Errors::RequestTimeout => e
+        puts "Couldn't confirm green status.\n#{e.inspect}."
+      rescue Faraday::ConnectionFailed => e
+        puts "Couldn't connect to Elasticsearch.\n#{e.inspect}."
         sleep(30)
       end
     end
@@ -34,20 +33,18 @@ namespace :elasticsearch do
     end
   end
 
-  desc "Update the submodule with Elasticsearch core repository"
-  task :update => :setup do
+  desc 'Update the submodule with Elasticsearch core repository'
+  task update: :setup do
     sh "git --git-dir=#{CURRENT_PATH.join('tmp/elasticsearch/.git')} --work-tree=#{CURRENT_PATH.join('tmp/elasticsearch')} fetch origin --quiet"
     begin
       %x[git --git-dir=#{CURRENT_PATH.join('tmp/elasticsearch/.git')} --work-tree=#{CURRENT_PATH.join('tmp/elasticsearch')} pull]
-    rescue Exception => @exception
+    rescue Exception => @e
       @failed = true
     end
 
-    if @failed || !$?.success?
-      STDERR.puts "", "[!] Error while pulling -- #{@exception}"
-    end
+    STDERR.puts '', "[!] Error while pulling -- #{@e}" if @failed || !$?.success?
 
-    puts "\n", "CHANGES:", '-'*80
+    puts "\n", "CHANGES:", '-' * 80
     sh "git --git-dir=#{CURRENT_PATH.join('tmp/elasticsearch/.git')} --work-tree=#{CURRENT_PATH.join('tmp/elasticsearch')} log --oneline ORIG_HEAD..HEAD | cat", :verbose => false
   end
 
@@ -62,7 +59,7 @@ namespace :elasticsearch do
   DESC
   task :build, :branch do |task, args|
     Rake::Task['elasticsearch:status'].invoke
-    puts '-'*80
+    puts '-' * 80
 
     gitref = args[:branch] || 'origin/master'
     es_version = gitref.gsub(/^v|origin\/(\d\.+)/, '\1').to_f

rake_tasks/test_tasks.rake

@@ -1,47 +1,49 @@
-UNIT_TESTED_PROJECTS = [ 'elasticsearch',
-                         'elasticsearch-transport',
-                         'elasticsearch-dsl',
-                         'elasticsearch-api',
-                         'elasticsearch-xpack',
-                         'elasticsearch-extensions' ].freeze
+UNIT_TESTED_PROJECTS = [
+  'elasticsearch',
+  'elasticsearch-transport',
+  'elasticsearch-dsl',
+  'elasticsearch-api',
+  'elasticsearch-xpack',
+  'elasticsearch-extensions'
+].freeze
 
 INTEGRATION_TESTED_PROJECTS = (UNIT_TESTED_PROJECTS - ['elasticsearch-api']).freeze
 
 namespace :test do
-  task :bundle => 'bundle:install'
+  task bundle: 'bundle:install'
 
-  desc "Run all tests in all subprojects"
-  task :client => [ :unit, :integration ]
+  desc 'Run all tests in all subprojects'
+  task client: [:unit, :integration]
 
-  desc "Run unit tests in all subprojects"
+  desc 'Run unit tests in all subprojects'
   task :unit do
     UNIT_TESTED_PROJECTS.each do |project|
-      puts '-'*80
+      puts '-' * 80
       sh "cd #{CURRENT_PATH.join(project)} && unset BUNDLE_GEMFILE && unset BUNDLE_PATH && unset BUNDLE_BIN && bundle exec rake test:unit"
       puts "\n"
     end
   end
 
-  desc "Run integration tests in all subprojects"
+  desc 'Run integration tests in all subprojects'
   task :integration do
     INTEGRATION_TESTED_PROJECTS.each do |project|
-      puts '-'*80
+      puts '-' * 80
       sh "cd #{CURRENT_PATH.join(project)} && unset BUNDLE_GEMFILE && bundle exec rake test:integration"
       puts "\n"
     end
   end
 
   # Note: Start Elasticsearch with the following command if Docker is not used.
   # bin/elasticsearch -Erepositories.url.allowed_urls=http://* -Epath.repo=/tmp -Enode.attr.testattr=test
-  desc "Run rest api tests"
-  task :rest_api => ['elasticsearch:update', 'elasticsearch:wait_for_green'] do
+  desc 'Run rest api tests'
+  task rest_api: ['elasticsearch:update', 'elasticsearch:wait_for_green'] do
     puts '-' * 80
     sh "cd #{CURRENT_PATH.join('elasticsearch-api')} && unset BUNDLE_GEMFILE && bundle exec rake test:integration"
     puts "\n"
   end
 
-  desc "Run security (Platinum) rest api yaml tests"
-  task :security => 'elasticsearch:update' do
+  desc 'Run security (Platinum) rest api yaml tests'
+  task security: 'elasticsearch:update' do
     Rake::Task['elasticsearch:wait_for_green'].invoke
     Rake::Task['elasticsearch:checkout_build'].invoke
     puts '-' * 80
@@ -50,13 +52,13 @@ namespace :test do
   end
 
   namespace :cluster do
-    desc "Start Elasticsearch nodes for tests"
+    desc 'Start Elasticsearch nodes for tests'
     task :start do
       require 'elasticsearch/extensions/test/cluster'
       Elasticsearch::Extensions::Test::Cluster.start
     end
 
-    desc "Stop Elasticsearch nodes for tests"
+    desc 'Stop Elasticsearch nodes for tests'
     task :stop do
       require 'elasticsearch/extensions/test/cluster'
       Elasticsearch::Extensions::Test::Cluster.stop