Problems with pagination in MultiModel Search

[miguelespada]

I try to use pagination with Kaminari in a MultiModel Search.

This is my call:
Elasticsearch::Model.search(query, [AAA, BBB]).page(1).results

This is the error:
Failure/Error: response = MultiModelSearch.search('xxx')
NoMethodError:
undefined method `default_per_page' for #Elasticsearch::Model::Multimodel:0x007ff9dbe4f520

Is pagination supported for multimodel?

[xpepermint]

+1

[miguelespada]

It works with will_paginate

Elasticsearch::Model.search(query, [AAA, BBB]).per_page(25).page(1).results

[karmi]

@miguelespada Don't know from top of my head, we'll look into that.

@miguelff, would you spare some time to look at the issue, please?

[miguelff]

Sure, I will look into as soon as I got some time.

[miguelff]

One question @miguelespada, does the Gemfile of your application declare gem 'kaminari' before gem 'elasticsearch-rails'?

[xpepermint]

Btw... I have kaminari before elasticsearch-rails.

[miguelespada]

Hi @miguelff,
I do have kaminari before ES

gem "kaminari"
gem 'elasticsearch-model', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'
gem 'elasticsearch-rails', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'

[kikyous]

+1

[kikyous]

@miguelespada , @miguelff
add default_per_page method simply works for me

module Elasticsearch
  module Model
    class Multimodel
      def default_per_page
        10
      end
    end
  end
end

[miguelff]

Thanks for the feedback, I will tackle the issue as soon as I got some time. Before the end of the week.

[miguelff]

Working on this.

[xpepermint]

thx!

[miguelff]

Waiting for @karmi's review

[karmi]

Should be solved by @miguelff patch in #408 now!

[miguelespada]

Thanks! @miguelff and @karmi

[rkrdo]

Are you guys planning on releasing a version on rubygems with this patch?
Also, what would be safer to use in the meantime, reference the gem to master or to the specific commit?

[karmi]

@rkrdo Absolutely, I'm processing issues on the elasticsearch-ruby repository this week, I hope I'll get to the Rails one first. If it would be a blocker for you, there's no trouble in releasing a version, but I'd like to accumulate more patches in that first.

In the Gemfile, I'd rather go with a specific commit -- master should be always safe in terms of not suddenly breaking compatibility or having bugs, but of course it might happen...

[rkrdo]

@karmi Makes sense, I'll reference a specific commit until you guys have enough patches to release a new version for now, thanks!