Validate .update method

kkirsche · kkirsche · commit 1c4a72e968a0 · 2014-11-17T12:25:02.000-05:00
Follow rails convention by returning false unless the item is valid.
diff --git a/elasticsearch-persistence/lib/elasticsearch/persistence/model/store.rb b/elasticsearch-persistence/lib/elasticsearch/persistence/model/store.rb
@@ -99,6 +99,7 @@ def destroy(options={})
           # @return [Hash] The Elasticsearch response as a Hash
           #
           def update(attributes={}, options={})
+            return false unless valid?
             raise DocumentNotPersisted, "Object not persisted: #{self.inspect}" unless persisted?
 
             run_callbacks :update do

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ def destroy(options={})`
`99`	`99`	`# @return [Hash] The Elasticsearch response as a Hash`
`100`	`100`	`#`
`101`	`101`	`def update(attributes={}, options={})`
	`102`	`+ return false unless valid?`
`102`	`103`	`raise DocumentNotPersisted, "Object not persisted: #{self.inspect}" unless persisted?`
`103`	`104`
`104`	`105`	`run_callbacks :update do`