Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force_source and phrase_limit parameters missing to build highlight queries #185

Closed
sothawo opened this issue Mar 6, 2022 · 1 comment · Fixed by #292
Closed

force_source and phrase_limit parameters missing to build highlight queries #185

sothawo opened this issue Mar 6, 2022 · 1 comment · Fixed by #292
Labels
Area: Specification Related to the API spec used to generate client code

Comments

@sothawo
Copy link
Contributor

sothawo commented Mar 6, 2022

Java API client version

7.17.1

Java version

openjdk version "1.8.0_322@

Elasticsearch Version

7.17.1

Problem description

Highlighting has the parameters force_source and phrase_limit for the highlight itself and for highlight fields (https://www.elastic.co/guide/en/elasticsearch/reference/8.0/highlighting.html).

Both parameters are missing in co.elastic.clients.elasticsearch.core.search.Highlight. They are available for co.elastic.clients.elasticsearch.core.search.HighlightField but according to the docs and implementation in the old client, they should be available in Highlight as well.

@swallez
Copy link
Member

swallez commented May 24, 2022

This has been fixed in PR #292, backported to version 8.2 in PR #293 and to version 7.17 in PR #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants