Handle race condition in outOfLineINL

In the below example, compareAndExchangeRelease translates to an
OutOfLine INL method named
OutOfLineINL_jdk_internal_misc_Unsafe_compareAndExchangeIntVolatile.

Example:
InstFieldVH <- InstanceFieldVarHandle provides access to an int field in
an object.
1000 threads concurrently execute {
	int old, new;
	do {
		old = (int)InstFieldVH.getVolatile(object);
		new = old + 2;
	} while (old != InstFieldVH.compareAndExchangeRelease(object, old,
new));
}

There is a race condition between 1) invoking the target method in
BytecodeInterpreter.hpp::outOfLineINL; and 2) resolving the native
address (J9Method->extra) of the target method in
BytecodeInterpreter.hpp::bindNative.

Due to the race condition, the native address of the target method may
not be resolved when certain threads invoke outOfLineINL. In such cases,
outOfLineINL should resolve the native address before proceeding. 

bindnatv.cpp::resolveNativeAddress - The code to resolve the native
address is protected by the J9JavaVM->bindNativeMutex. So, it can be
safely invoked by multiple threads. If the native address is already
resolved, then it returns without repeating the resolution process.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>

Author: babsingh

Diff for: runtime/vm/BytecodeInterpreter.hpp

@@ -2019,40 +2019,50 @@ obj:;
 	}
 
 	VMINLINE VM_BytecodeAction
-	bindNative(REGISTER_ARGS_LIST)
+	resolveNativeAddressWithErrorHandling()
 	{
-		VM_BytecodeAction rc = GOTO_RUN_METHOD;
-		buildMethodFrame(REGISTER_ARGS, _sendMethod, jitStackFrameFlags(REGISTER_ARGS, 0));
-		updateVMStruct(REGISTER_ARGS);
 		UDATA bindRC = resolveNativeAddress(_currentThread, _sendMethod, TRUE);
 		if (J9_NATIVE_METHOD_BIND_OUT_OF_MEMORY == bindRC) {
 			_vm->memoryManagerFunctions->j9gc_modron_global_collect_with_overrides(_currentThread, J9MMCONSTANT_EXPLICIT_GC_NATIVE_OUT_OF_MEMORY);
 			bindRC = resolveNativeAddress(_currentThread, _sendMethod, TRUE);
 		}
-		switch(bindRC) {
-		case J9_NATIVE_METHOD_BIND_SUCCESS: {
-			VMStructHasBeenUpdated(REGISTER_ARGS);
-			J9SFMethodFrame *methodFrame = (J9SFMethodFrame*)_sp;
-			_currentThread->jitStackFrameFlags = methodFrame->specialFrameFlags & J9_SSF_JIT_NATIVE_TRANSITION_FRAME;
-			restoreSpecialStackFrameLeavingArgs(REGISTER_ARGS, ((UDATA*)(methodFrame + 1)) - 1);
-			break;
-		}
-		case J9_NATIVE_METHOD_BIND_OUT_OF_MEMORY:
-			setNativeBindOutOfMemoryError(_currentThread, _sendMethod);
-			VMStructHasBeenUpdated(REGISTER_ARGS);
-			rc = GOTO_THROW_CURRENT_EXCEPTION;
-			break;
-		case J9_NATIVE_METHOD_BIND_RECURSIVE:
-			setRecursiveBindError(_currentThread, _sendMethod);
-			VMStructHasBeenUpdated(REGISTER_ARGS);
-			rc = GOTO_THROW_CURRENT_EXCEPTION;
-			break;
-		default:
-			setNativeNotFoundError(_currentThread, _sendMethod);
-			VMStructHasBeenUpdated(REGISTER_ARGS);
+
+		VM_BytecodeAction rc = GOTO_RUN_METHOD;
+		if (J9_NATIVE_METHOD_BIND_SUCCESS != bindRC) {
 			rc = GOTO_THROW_CURRENT_EXCEPTION;
-			break;
+			switch(bindRC) {
+			case J9_NATIVE_METHOD_BIND_OUT_OF_MEMORY:
+				setNativeBindOutOfMemoryError(_currentThread, _sendMethod);
+				break;
+			case J9_NATIVE_METHOD_BIND_RECURSIVE:
+				setRecursiveBindError(_currentThread, _sendMethod);
+				break;
+			default:
+				setNativeNotFoundError(_currentThread, _sendMethod);
+				break;
+			}
 		}
+
+		return rc;
+	}
+
+	VMINLINE VM_BytecodeAction
+	bindNative(REGISTER_ARGS_LIST)
+	{
+		VM_BytecodeAction rc = GOTO_RUN_METHOD;
+
+		buildMethodFrame(REGISTER_ARGS, _sendMethod, jitStackFrameFlags(REGISTER_ARGS, 0));
+
+		updateVMStruct(REGISTER_ARGS);
+		rc = resolveNativeAddressWithErrorHandling();
+		VMStructHasBeenUpdated(REGISTER_ARGS);
+
+		if (GOTO_RUN_METHOD == rc) {
+			J9SFMethodFrame *methodFrame = (J9SFMethodFrame *)_sp;
+			_currentThread->jitStackFrameFlags = methodFrame->specialFrameFlags & J9_SSF_JIT_NATIVE_TRANSITION_FRAME;
+			restoreSpecialStackFrameLeavingArgs(REGISTER_ARGS, ((UDATA *)(methodFrame + 1)) - 1);
+		}
+
 		return rc;
 	}
 
@@ -4618,8 +4628,21 @@ done:;
 	outOfLineINL(REGISTER_ARGS_LIST)
 	{
 		updateVMStruct(REGISTER_ARGS);
+
 		J9OutOfLineINLMethod *target = (J9OutOfLineINLMethod *)(((UDATA)_sendMethod->extra) & ~J9_STARTPC_NOT_TRANSLATED);
-		VM_BytecodeAction rc = target(_currentThread, _sendMethod);
+		VM_BytecodeAction rc = GOTO_RUN_METHOD;
+		if (NULL == target) {
+			/* Resolve the native address and retry. */
+			rc = resolveNativeAddressWithErrorHandling();
+			if (GOTO_RUN_METHOD != rc) {
+				goto done;
+			}
+			target = (J9OutOfLineINLMethod *)(((UDATA)_sendMethod->extra) & ~J9_STARTPC_NOT_TRANSLATED);
+		}
+
+		Assert_VM_true(NULL != target);
+		rc = target(_currentThread, _sendMethod);
+done:
 		VMStructHasBeenUpdated(REGISTER_ARGS);
 		return rc;
 	}