Add JITServer support for LambdaForm methods inlining

This commit adds support for changes introduced in #12162.
New interpreter emulator code that requires holding VM
access while accessing object on the heap is wrapped in front-end
calls enabling it to be done safely on JITServer.

Signed-off-by: Dmitry Ten <Dmitry.Ten@ibm.com>

Author: dmitry-ten

Diff for: runtime/compiler/control/JITClientCompilationThread.cpp

@@ -492,6 +492,13 @@ handleServerMessage(JITServer::ClientStream *client, TR_J9VM *fe, JITServer::Mes
          client->write(response, fe->getObjectClassAt(objectAddress));
          }
          break;
+      case MessageType::VM_getObjectClassFromKnownObjectIndex:
+         {
+         auto recv = client->getRecvData<TR::KnownObjectTable::Index>();
+         auto idx = std::get<0>(recv);
+         client->write(response, fe->getObjectClassFromKnownObjectIndex(comp, idx));
+         }
+         break;
       case MessageType::VM_getStaticReferenceFieldAtAddress:
          {
          TR::VMAccessCriticalSection getStaticReferenceFieldAtAddress(fe);

Diff for: runtime/compiler/env/VMJ9.cpp

@@ -1125,6 +1125,16 @@ TR_J9VMBase::getObjectClassAt(uintptr_t objectAddress)
    return getObjectClass(getStaticReferenceFieldAtAddress(objectAddress));
    }
 
+TR_OpaqueClassBlock *
+TR_J9VMBase::getObjectClassFromKnownObjectIndex(TR::Compilation *comp, TR::KnownObjectTable::Index idx)
+   {
+   TR::VMAccessCriticalSection getObjectClassFromKnownObjectIndex(comp, TR::VMAccessCriticalSection::tryToAcquireVMAccess);
+   TR_OpaqueClassBlock *clazz = NULL;
+   if (getObjectClassFromKnownObjectIndex.hasVMAccess())
+      clazz = getObjectClass(comp->getKnownObjectTable()->getPointer(idx));
+   return clazz;
+   }
+
 uintptr_t
 TR_J9VMBase::getStaticReferenceFieldAtAddress(uintptr_t fieldAddress)
    {

Diff for: runtime/compiler/env/VMJ9.h

@@ -534,6 +534,7 @@ class TR_J9VMBase : public TR_FrontEnd
 
    virtual TR_OpaqueClassBlock *getObjectClass(uintptr_t objectPointer);
    virtual TR_OpaqueClassBlock *getObjectClassAt(uintptr_t objectAddress);
+   virtual TR_OpaqueClassBlock *getObjectClassFromKnownObjectIndex(TR::Compilation *comp, TR::KnownObjectTable::Index idx);
    virtual uintptr_t           getReferenceFieldAt(uintptr_t objectPointer, uintptr_t offsetFromHeader);
    virtual uintptr_t           getVolatileReferenceFieldAt(uintptr_t objectPointer, uintptr_t offsetFromHeader);
    virtual uintptr_t           getReferenceFieldAtAddress(uintptr_t fieldAddress);

Diff for: runtime/compiler/env/VMJ9Server.cpp

@@ -853,6 +853,14 @@ TR_J9ServerVM::getObjectClassAt(uintptr_t objectAddress)
    return std::get<0>(stream->read<TR_OpaqueClassBlock *>());
    }
 
+TR_OpaqueClassBlock *
+TR_J9ServerVM::getObjectClassFromKnownObjectIndex(TR::Compilation *comp, TR::KnownObjectTable::Index idx)
+   {
+   JITServer::ServerStream *stream = _compInfoPT->getMethodBeingCompiled()->_stream;
+   stream->write(JITServer::MessageType::VM_getObjectClassFromKnownObjectIndex, idx);
+   return std::get<0>(stream->read<TR_OpaqueClassBlock *>());
+   }
+
 uintptr_t
 TR_J9ServerVM::getStaticReferenceFieldAtAddress(uintptr_t fieldAddress)
    {

Diff for: runtime/compiler/env/VMJ9Server.hpp

@@ -103,6 +103,7 @@ class TR_J9ServerVM: public TR_J9VM
    virtual uint32_t getAllocationSize(TR::StaticSymbol *classSym, TR_OpaqueClassBlock *clazz) override;
    virtual TR_OpaqueClassBlock * getObjectClass(uintptr_t objectPointer) override;
    virtual TR_OpaqueClassBlock * getObjectClassAt(uintptr_t objectAddress) override;
+   virtual TR_OpaqueClassBlock *getObjectClassFromKnownObjectIndex(TR::Compilation *comp, TR::KnownObjectTable::Index idx) override;
    virtual uintptr_t getStaticReferenceFieldAtAddress(uintptr_t fieldAddress) override;
 
    virtual bool stackWalkerMaySkipFrames(TR_OpaqueMethodBlock *method, TR_OpaqueClassBlock *clazz) override;

Diff for: runtime/compiler/net/CommunicationStream.hpp

@@ -99,7 +99,7 @@ class CommunicationStream
    ClientMessage _cMsg;
 
    static const uint8_t MAJOR_NUMBER = 1;
-   static const uint16_t MINOR_NUMBER = 24;
+   static const uint16_t MINOR_NUMBER = 25;
    static const uint8_t PATCH_NUMBER = 0;
    static uint32_t CONFIGURATION_FLAGS;
 

Diff for: runtime/compiler/net/MessageTypes.hpp

@@ -120,6 +120,7 @@ enum MessageType : uint16_t
    VM_getMethods,
    VM_getObjectClass,
    VM_getObjectClassAt,
+   VM_getObjectClassFromKnownObjectIndex,
    VM_stackWalkerMaySkipFrames,
    VM_getStringUTF8Length,
    VM_classInitIsFinished,
@@ -363,6 +364,7 @@ static const char *messageNames[] =
    "VM_getMethods",
    "VM_getObjectClass",
    "VM_getObjectClassAt",
+   "VM_getObjectClassFromKnownObjectIndex",
    "VM_stackWalkerMaySkipFrames",
    "VM_getStringUTF8Length",
    "VM_classInitIsFinished",

Diff for: runtime/compiler/optimizer/InterpreterEmulator.cpp

@@ -62,21 +62,7 @@ KnownObjOperand::getClass()
    if (!knot || knot->isNull(knownObjIndex))
       return NULL;
 
-#if defined(J9VM_OPT_JITSERVER)
-   // TODO: add JITServer support
-   if (comp->isOutOfProcessCompilation())
-      return NULL;
-   else
-#endif
-      {
-      TR::VMAccessCriticalSection KnownObjOperandCriticalSection(comp,
-                                                                 TR::VMAccessCriticalSection::tryToAcquireVMAccess);
-
-      if (KnownObjOperandCriticalSection.hasVMAccess())
-         {
-         _clazz = TR::Compiler->cls.objectClass(comp, knot->getPointer(knownObjIndex));
-         }
-      }
+   _clazz = comp->fej9()->getObjectClassFromKnownObjectIndex(comp, knownObjIndex);
 
    return _clazz;
    }
@@ -868,10 +854,7 @@ InterpreterEmulator::getReturnValue(TR_ResolvedMethod *callee)
          TR::KnownObjectTable *knot = comp()->getKnownObjectTable();
          if (knot && mhIndex != TR::KnownObjectTable::UNKNOWN && !knot->isNull(mhIndex))
             {
-            TR::VMAccessCriticalSection dereferenceKnownObjectField(comp()->fej9());
-            uintptr_t mhObjectAddress = knot->getPointer(mhIndex);
-            uintptr_t memberAddress = comp()->fej9()->getReferenceField(mhObjectAddress, "member", "Ljava/lang/invoke/MemberName;");
-            TR::KnownObjectTable::Index memberIndex = knot->getOrCreateIndex(memberAddress);
+            TR::KnownObjectTable::Index memberIndex = comp()->fej9()->getMemberNameFieldKnotIndexFromMethodHandleKnotIndex(comp(), mhIndex, "member");
             debugTrace(tracer(), "Known internal member name koi %d\n", memberIndex);
             result = new (trStackMemory()) KnownObjOperand(memberIndex);
             }
@@ -885,10 +868,7 @@ InterpreterEmulator::getReturnValue(TR_ResolvedMethod *callee)
          TR::KnownObjectTable *knot = comp()->getKnownObjectTable();
          if (knot && mhIndex != TR::KnownObjectTable::UNKNOWN && !knot->isNull(mhIndex))
             {
-            TR::VMAccessCriticalSection dereferenceKnownObjectField(comp()->fej9());
-            uintptr_t mhObjectAddress = knot->getPointer(mhIndex);
-            uintptr_t memberNameObject = comp()->fej9()->getReferenceField(mhObjectAddress, "initMethod", "Ljava/lang/invoke/MemberName;");
-            TR::KnownObjectTable::Index memberIndex = knot->getOrCreateIndex(memberNameObject);
+            TR::KnownObjectTable::Index memberIndex = comp()->fej9()->getMemberNameFieldKnotIndexFromMethodHandleKnotIndex(comp(), mhIndex, "initMethod");
             debugTrace(tracer(), "Known internal member name koi %d\n", memberIndex);
             result = new (trStackMemory()) KnownObjOperand(memberIndex);
             }
@@ -1131,7 +1111,7 @@ InterpreterEmulator::visitInvokedynamic()
 #if defined(J9VM_OPT_OPENJDK_METHODHANDLE)
    if (owningMethod->isUnresolvedCallSiteTableEntry(callSiteIndex)
          || comp()->compileRelocatableCode()
-      ) return; // do nothing if unresolved, is AOT or JITServer compilation
+      ) return; // do nothing if unresolved, is AOT compilation
    uintptr_t * invokeCacheArray = (uintptr_t *) owningMethod->callSiteTableEntryAddress(callSiteIndex);
    updateKnotAndCreateCallSiteUsingInvokeCacheArray(owningMethod, invokeCacheArray, -1);
 #else