Fix C4800

```
warning C4800: 'uint32_t' : forcing value to bool 'true' or 'false' (performance warning)
```

Author: fjeremic

compiler/compile/OMRCompilation.cpp

@@ -776,7 +776,7 @@ OMR::Compilation::getOSRTransitionTarget()
 bool
 OMR::Compilation::isOSRTransitionTarget(TR::OSRTransitionTarget target)
    {
-   return target & self()->getOSRTransitionTarget();
+   return (target & self()->getOSRTransitionTarget()) != 0;
    }
 
 /*

compiler/control/OMROptions.cpp

@@ -4522,7 +4522,7 @@ OMR::Options::checkDisableFlagForAllMethods(OMR::Optimizations o, bool b)
 char *
 OMR::Options::setStaticBool(char *option, void *base, TR::OptionTable *entry)
    {
-   *((bool*)entry->parm1) = (bool)entry->parm2;
+   *((bool*)entry->parm1) = (entry->parm2 != 0);
    return option;
    }
 

compiler/cs2/bitvectr.h

@@ -398,7 +398,7 @@ class ABitVector : private Allocator {
       wordIndex = fIndex / kBitWordSize;
       bitIndex = fIndex % kBitWordSize;
 
-      bitValue = (fVector.WordAt(wordIndex) << bitIndex) >> (kBitWordSize - 1);
+      bitValue = ((fVector.WordAt(wordIndex) << bitIndex) >> (kBitWordSize - 1)) != 0;
       return bitValue;
     }
 
@@ -476,7 +476,7 @@ inline bool ABitVector<Allocator>::ValueAt (BitIndex bitIndex) const {
   wordIndex = bitIndex / kBitWordSize;
   bitIndex = bitIndex % kBitWordSize;
 
-  return (WordAt(wordIndex) << bitIndex) >> (kBitWordSize - 1);
+  return ((WordAt(wordIndex) << bitIndex) >> (kBitWordSize - 1)) != 0;
 }
 
 template <class Allocator>

compiler/il/OMRResolvedMethodSymbol.cpp

@@ -2398,7 +2398,7 @@ OMR::ResolvedMethodSymbol::isParmVariant(TR::ParameterSymbol * parmSymbol)
                   "Parm %d (%p) cannot be owned by current method that only has %d parms", parmSymbol->getOrdinal(), parmSymbol, numberOfParameters);
    TR_ASSERT_FATAL(self()->getParmSymRef(parmSymbol->getSlot())->getSymbol()->getParmSymbol() == parmSymbol,
                   "Parm %p is not owned by current method %s", parmSymbol, self()->signature(self()->comp()->trMemory()));
-   return _variantParms->get(parmSymbol->getOrdinal());
+   return _variantParms->get(parmSymbol->getOrdinal()) != 0;
    }
 
 void

compiler/infra/Assert.cpp

@@ -199,7 +199,7 @@ namespace TR
       {
       if (!_node) return;
 
-      static bool printFullContext = feGetEnv("TR_AssertFullContext");
+      static bool printFullContext = feGetEnv("TR_AssertFullContext") != NULL;
       TR::Compilation *comp = TR::comp();
       TR_Debug *debug = comp->findOrCreateDebug();
 
@@ -250,7 +250,7 @@ namespace TR
       {
       if (!_instruction) return;
 
-      static bool printFullContext = feGetEnv("TR_AssertFullContext");
+      static bool printFullContext = feGetEnv("TR_AssertFullContext") != NULL;
       static int numInstructionsInContext = feGetEnv("TR_AssertNumInstructionsInContext") ?
          atoi(feGetEnv("TR_AssertNumInstructionsInContext")) : 11;
       TR_Debug *debug = TR::comp()->findOrCreateDebug();

compiler/infra/BitVector.cpp

@@ -241,7 +241,7 @@ bool TR_BitContainer::intersects(TR_BitVector& v2)
    else if (_type == bitvector)
       return false;
    else
-      return v2.get(_singleBit);
+      return v2.get(_singleBit) != 0;
    }
 
 bool TR_BitContainer::intersects(TR_BitContainer& v2)
@@ -254,7 +254,7 @@ bool TR_BitContainer::intersects(TR_BitContainer& v2)
       {
       // v2 is singleton
       if (_type == bitvector && _bitVector)
-         return get(v2._singleBit);
+         return get(v2._singleBit) != 0;
       else if (_type == bitvector)
          return false;
       else

compiler/infra/BitVector.hpp

@@ -429,7 +429,7 @@ class TR_BitVector
    // value had been set
    bool clear(int64_t n)
       {
-      bool rc = get(n);
+      bool rc = get(n) != 0;
       if (rc)
          reset(n);
 #if BV_SANITY_CHECK

compiler/infra/OMRCfg.cpp

@@ -667,22 +667,22 @@ TR::CFGEdge * TR::CFGNode::getExceptionPredecessorEdge(TR::CFGNode * n)
 
 bool TR::CFGNode::hasSuccessor(TR::CFGNode * n)
    {
-   return (bool)getSuccessorEdge(n);
+   return getSuccessorEdge(n) != NULL;
    }
 
 bool TR::CFGNode::hasExceptionSuccessor(TR::CFGNode * n)
    {
-   return (bool)getExceptionSuccessorEdge(n);
+   return getExceptionSuccessorEdge(n) != NULL;
    }
 
 bool TR::CFGNode::hasPredecessor(TR::CFGNode * n)
    {
-   return (bool)getPredecessorEdge(n);
+   return getPredecessorEdge(n) != NULL;
    }
 
 bool TR::CFGNode::hasExceptionPredecessor(TR::CFGNode * n)
    {
-   return (bool)getExceptionPredecessorEdge(n);
+   return getExceptionPredecessorEdge(n) != NULL;
    }
 
 

compiler/infra/SimpleRegex.cpp

@@ -373,7 +373,7 @@ bool SimpleRegex::Simple::match(const char *s, bool isCaseSensitive, bool useLoc
 
 bool SimpleRegex::Regex::match(const char *s, bool isCaseSensitive, bool useLocale)
    {
-   int32_t rc = false;
+   bool rc = false;
    for (Regex *p = this; p && !rc; p = p->remainder)
       {
       rc = p->simple->match(s, isCaseSensitive, useLocale);

compiler/optimizer/DeadTreesElimination.cpp

@@ -629,7 +629,7 @@ void TR::DeadTreesElimination::prePerformOnBlocks()
           && tt->getPrevTreeTop()->getNode()->getOpCodeValue() == TR::BBStart
           && !tt->getPrevTreeTop()->getNode()->getBlock()->isExtensionOfPreviousBlock())
          {
-         requestOpt(OMR::redundantGotoElimination, tt->getEnclosingBlock());
+         requestOpt(OMR::redundantGotoElimination, true, tt->getEnclosingBlock());
          }
 
       if (node->getVisitCount() >= visitCount)
@@ -1003,6 +1003,7 @@ int32_t TR::DeadTreesElimination::process(TR::TreeTop *startTree, TR::TreeTop *e
                   {
                   requestOpt(
                      OMR::redundantGotoElimination,
+                     true,
                      prevTree->getNode()->getBlock());
                   }
                }