Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit a96985f

Browse files
authored
Update to autofill DAU reporting for iOS credential provider extension (#3763)
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f Tech Design URL: CC: **Description**: Minor update to support BSK change to AutofillPixelReporter
1 parent 8080c1f commit a96985f

File tree

12 files changed

+15
-13
lines changed

12 files changed

+15
-13
lines changed

DuckDuckGo-macOS.xcodeproj/project.pbxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -15570,7 +15570,7 @@
1557015570
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
1557115571
requirement = {
1557215572
kind = exactVersion;
15573-
version = 233.0.0;
15573+
version = 233.1.0;
1557415574
};
1557515575
};
1557615576
9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
"kind" : "remoteSourceControl",
3333
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
3434
"state" : {
35-
"revision" : "c5bf6b03bb683c5b08fa34e74a96fa3548d2a287",
36-
"version" : "233.0.0"
35+
"revision" : "b874310b6db6687ef6be5f978edf2f5d03b7fc69",
36+
"version" : "233.1.0"
3737
}
3838
},
3939
{

DuckDuckGo/Application/AppDelegate.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,8 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
860860

861861
private func setUpAutofillPixelReporter() {
862862
autofillPixelReporter = AutofillPixelReporter(
863-
userDefaults: .standard,
863+
standardUserDefaults: .standard,
864+
appGroupUserDefaults: nil,
864865
autofillEnabled: AutofillPreferences().askToSaveUsernamesAndPasswords,
865866
eventMapping: EventMapping<AutofillPixelEvent> {event, _, params, _ in
866867
switch event {

DuckDuckGo/Menus/MainMenuActions.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,8 @@ extension MainViewController {
849849
}
850850
UserDefaults.standard.set(false, forKey: UserDefaultsWrapper<Bool>.Key.homePageContinueSetUpImport.rawValue)
851851

852-
let autofillPixelReporter = AutofillPixelReporter(userDefaults: .standard,
852+
let autofillPixelReporter = AutofillPixelReporter(standardUserDefaults: .standard,
853+
appGroupUserDefaults: nil,
853854
autofillEnabled: AutofillPreferences().askToSaveUsernamesAndPasswords,
854855
eventMapping: EventMapping<AutofillPixelEvent> { _, _, _, _ in },
855856
installDate: nil)

LocalPackages/DataBrokerProtection/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ let package = Package(
2929
targets: ["DataBrokerProtection"])
3030
],
3131
dependencies: [
32-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
32+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3333
.package(path: "../SwiftUIExtensions"),
3434
.package(path: "../AppKitExtensions"),
3535
.package(path: "../XPCHelper"),

LocalPackages/FeatureFlags/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ let package = Package(
3232
targets: ["FeatureFlags"]),
3333
],
3434
dependencies: [
35-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
35+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3636
],
3737
targets: [
3838
// Targets are the basic building blocks of a package, defining a module or a test suite.

LocalPackages/HistoryView/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ let package = Package(
3232
targets: ["HistoryView"]),
3333
],
3434
dependencies: [
35-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
35+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3636
.package(path: "../WebKitExtensions"),
3737
.package(path: "../UserScriptActionsManager"),
3838
.package(path: "../Utilities"),

LocalPackages/NetworkProtectionMac/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ let package = Package(
3333
.library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
3434
],
3535
dependencies: [
36-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
36+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3737
.package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.3"),
3838
.package(path: "../AppLauncher"),
3939
.package(path: "../UDSHelper"),

LocalPackages/NewTabPage/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ let package = Package(
3232
targets: ["NewTabPage"]),
3333
],
3434
dependencies: [
35-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
35+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3636
.package(path: "../WebKitExtensions"),
3737
.package(path: "../UserScriptActionsManager"),
3838
.package(path: "../Utilities"),

LocalPackages/SubscriptionUI/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ let package = Package(
1313
targets: ["SubscriptionUI"]),
1414
],
1515
dependencies: [
16-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
16+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
1717
.package(path: "../PreferencesUI-macOS"),
1818
.package(path: "../SwiftUIExtensions"),
1919
.package(path: "../FeatureFlags")

LocalPackages/UserScriptActionsManager/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ let package = Package(
3131
targets: ["UserScriptActionsManager"]),
3232
],
3333
dependencies: [
34-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
34+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3535
],
3636
targets: [
3737
.target(

LocalPackages/WebKitExtensions/Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ let package = Package(
3232
),
3333
],
3434
dependencies: [
35-
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.0.0"),
35+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "233.1.0"),
3636
.package(path: "../AppKitExtensions")
3737
],
3838
targets: [

0 commit comments

Comments
 (0)