Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 9f13ca4

Browse files
fix bug that opens bookmarks in same tab (#1495)
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205284729234368/f **Description**: When clicking on a bookmark from the bookmarks bar, a normal tap should open it in the current tab and CMD+CLICK should open it in a new tab. This will reinstate this behaviour and at the same time fix a behaviour when CMD+OPTION+NUMBER opened favorites on a new tab: https://app.asana.com/0/1177771139624306/1204216091208991/f
1 parent 4ce2b0f commit 9f13ca4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

DuckDuckGo/Windows/View/WindowControllersManager.swift

+2
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ extension WindowControllersManager {
124124
WindowsManager.openNewWindow(with: url, isBurner: false)
125125
} else if mainWindowController?.mainViewController.view.window?.isPopUpWindow ?? false {
126126
show(url: url, newTab: true)
127+
} else if NSApplication.shared.isCommandPressed && !NSApplication.shared.isOptionPressed {
128+
mainWindowController?.mainViewController.tabCollectionViewModel.appendNewTab(with: .url(url), selected: false)
127129
} else if selectedTab?.isPinned ?? false { // When selecting a bookmark with a pinned tab active, always open the URL in a new tab
128130
show(url: url, newTab: true)
129131
} else {

0 commit comments

Comments
 (0)