remove tabBarViewItemMenu; minor warning cleanup (#209)

Author: mallexxx

DuckDuckGo/TabBar/View/TabBarViewItem.swift

@@ -68,42 +68,6 @@ final class TabBarViewItem: NSCollectionViewItem {
         }
     }
 
-    var tabBarViewItemMenu: NSMenu {
-        let menu = NSMenu()
-
-        let duplicateMenuItem = NSMenuItem(title: UserText.duplicateTab, action: #selector(duplicateAction(_:)), keyEquivalent: "")
-        menu.addItem(duplicateMenuItem)
-
-        menu.addItem(NSMenuItem.separator())
-
-        let bookmarkMenuItem = NSMenuItem(title: UserText.bookmarkThisPage, action: #selector(bookmarkThisPageAction(_:)), keyEquivalent: "")
-        menu.addItem(bookmarkMenuItem)
-
-        if let url = currentURL, url.canFireproof {
-            let menuItem: NSMenuItem
-
-            if FireproofDomains.shared.isFireproof(fireproofDomain: url.host ?? "") {
-                menuItem = NSMenuItem(title: UserText.removeFireproofing, action: #selector(removeFireproofingAction(_:)), keyEquivalent: "")
-            } else {
-                menuItem = NSMenuItem(title: UserText.fireproofSite, action: #selector(fireproofSiteAction(_:)), keyEquivalent: "")
-            }
-
-            menu.addItem(menuItem)
-            menu.addItem(NSMenuItem.separator())
-        }
-
-        let closeMenuItem = NSMenuItem(title: UserText.closeTab, action: #selector(closeButtonAction(_:)), keyEquivalent: "")
-        menu.addItem(closeMenuItem)
-
-        let closeOtherMenuItem = NSMenuItem(title: UserText.closeOtherTabs, action: #selector(closeOtherAction(_:)), keyEquivalent: "")
-        menu.addItem(closeOtherMenuItem)
-
-        let moveToNewWindowMenuItem = NSMenuItem(title: UserText.moveTabToNewWindow, action: #selector(moveToNewWindowAction(_:)), keyEquivalent: "")
-        menu.addItem(moveToNewWindowMenuItem)
-
-        return menu
-    }
-
     var isLeftToSelected: Bool = false {
         didSet {
             updateSeparatorView()

Unit Tests/Common/StringExtensionTests.swift

@@ -20,7 +20,7 @@ import Foundation
 import XCTest
 @testable import DuckDuckGo_Privacy_Browser
 
-final class StringExtensionsTests: XCTestCase {
+final class StringExtensionTests: XCTestCase {
 
     // MARK: - General