Password Generation (#500)

Task/Issue URL: https://app.asana.com/0/0/1201969773101195/f
Tech Design URL:

Description:

Note: requires duckduckgo/BrowserServicesKit#81 to be released first.

Author: samsymons

DuckDuckGo.xcodeproj/project.pbxproj

@@ -5781,7 +5781,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 12.2.9;
+				version = 12.3.0;
 			};
 		};
 		AA06B6B52672AF8100F541C5 /* XCRemoteSwiftPackageReference "Sparkle" */ = {

DuckDuckGo/Common/Extensions/NSNotificationName+Debug.swift

@@ -22,6 +22,7 @@ import Foundation
 extension NSNotification.Name {
 
     static let ShowSaveCredentialsPopover = NSNotification.Name("ShowSaveCredentialsPopover")
+    static let ShowCredentialsSavedPopover = NSNotification.Name("ShowCredentialsSavedPopover")
 
 }
 #endif

DuckDuckGo/Common/Extensions/NSTextFieldExtension.swift

@@ -33,6 +33,13 @@ extension NSTextField {
         return label
     }
 
+    func setEditable(_ editable: Bool) {
+        self.isEditable = editable
+        self.isBordered = editable
+        self.isSelectable = editable
+        self.isBezeled = editable
+    }
+    
     static func optionalLabel(titled title: String?) -> NSTextField? {
         guard let title = title else {
             return nil

DuckDuckGo/Menus/MainMenu.storyboard

@@ -692,6 +692,12 @@ CQ
                                                             <action selector="showSaveCredentialsPopover:" target="Ady-hI-5gd" id="zgU-tH-zHa"/>
                                                         </connections>
                                                     </menuItem>
+                                                    <menuItem title="Show Credentials Saved Popover" id="Odn-Rg-Mjy">
+                                                        <modifierMask key="keyEquivalentModifierMask"/>
+                                                        <connections>
+                                                            <action selector="showCredentialsSavedPopover:" target="Ady-hI-5gd" id="f2c-5P-iB5"/>
+                                                        </connections>
+                                                    </menuItem>
                                                 </items>
                                             </menu>
                                         </menuItem>

DuckDuckGo/Menus/MainMenuActions.swift

@@ -511,6 +511,12 @@ extension MainViewController {
         NotificationCenter.default.post(name: .ShowSaveCredentialsPopover, object: nil)
         #endif
     }
+    
+    @IBAction func showCredentialsSavedPopover(_ sender: Any?) {
+        #if DEBUG || REVIEW
+        NotificationCenter.default.post(name: .ShowCredentialsSavedPopover, object: nil)
+        #endif
+    }
 
     // MARK: - Developer Tools
 

DuckDuckGo/Navigation Bar/View/NavigationBarViewController.swift

@@ -21,7 +21,7 @@ import Combine
 import os.log
 import BrowserServicesKit
 
-// swiftlint:disable type_body_length
+// swiftlint:disable type_body_length file_length
 final class NavigationBarViewController: NSViewController {
 
     enum Constants {
@@ -557,7 +557,7 @@ final class NavigationBarViewController: NSViewController {
         if autofillPreferences.askToSaveUsernamesAndPasswords, let credentials = data.credentials {
             os_log("Presenting Save Credentials popover", log: .passwordManager)
             showSaveCredentialsPopover()
-            saveCredentialsPopover.viewController.saveCredentials(credentials)
+            saveCredentialsPopover.viewController.update(credentials: credentials, automaticallySaved: data.automaticallySavedCredentials)
         } else if autofillPreferences.askToSavePaymentMethods, let card = data.creditCard {
             os_log("Presenting Save Payment Method popover", log: .passwordManager)
             showSavePaymentMethodPopover()
@@ -678,14 +678,26 @@ extension NavigationBarViewController {
         NotificationCenter.default.addObserver(forName: .ShowSaveCredentialsPopover, object: nil, queue: .main) { [weak self] _ in
             self?.showMockSaveCredentialsPopover()
         }
+        
+        NotificationCenter.default.addObserver(forName: .ShowCredentialsSavedPopover, object: nil, queue: .main) { [weak self] _ in
+            self?.showMockCredentialsSavedPopover()
+        }
     }
 
     fileprivate func showMockSaveCredentialsPopover() {
         let account = SecureVaultModels.WebsiteAccount(title: nil, username: "example-username", domain: "example.com")
         let mockCredentials = SecureVaultModels.WebsiteCredentials(account: account, password: "password".data(using: .utf8)!)
 
         showSaveCredentialsPopover()
-        saveCredentialsPopover.viewController.saveCredentials(mockCredentials)
+        saveCredentialsPopover.viewController.update(credentials: mockCredentials, automaticallySaved: false)
+    }
+    
+    fileprivate func showMockCredentialsSavedPopover() {
+        let account = SecureVaultModels.WebsiteAccount(title: nil, username: "example-username", domain: "example.com")
+        let mockCredentials = SecureVaultModels.WebsiteCredentials(account: account, password: "password".data(using: .utf8)!)
+        
+        showSaveCredentialsPopover()
+        saveCredentialsPopover.viewController.update(credentials: mockCredentials, automaticallySaved: true)
     }
 
 }

DuckDuckGo/Secure Vault/Extensions/UserText+PasswordManager.swift

@@ -21,6 +21,9 @@ import Foundation
 // swiftlint:disable line_length
 extension UserText {
 
+    static let pmSaveCredentialsEditableTitle = NSLocalizedString("pm.save-credentials.editable.title", value: "Save Login?", comment: "Title for the editable Save Credentials popover")
+    static let pmSaveCredentialsNonEditableTitle = NSLocalizedString("pm.save-credentials.non-editable.title", value: "New Login Saved", comment: "Title for the non-editable Save Credentials popover")
+    
     static let pmEmptyStateDefaultTitle = NSLocalizedString("pm.empty.default.title", value: "No Logins or Payment Methods saved yet", comment: "Label for default empty state title")
     static let pmEmptyStateDefaultDescription = NSLocalizedString("pm.empty.default.description",
                                                                   value: "If your logins are saved in another browser, you can import them into DuckDuckGo.",

DuckDuckGo/Secure Vault/Model/PasswordManagementLoginModel.swift

@@ -162,8 +162,8 @@ final class PasswordManagementLoginModel: ObservableObject, PasswordManagementIt
 
     private func populateViewModelFromCredentials() {
         let titleString = credentials?.account.title ?? ""
-        title =  titleString.isEmpty ? normalizedDomain(credentials?.account.domain ?? "") : titleString
 
+        title = titleString.isEmpty ? normalizedDomain(credentials?.account.domain ?? "") : titleString
         username = credentials?.account.username ?? ""
         password = String(data: credentials?.password ?? Data(), encoding: .utf8) ?? ""
         domain = normalizedDomain(credentials?.account.domain ?? "")