Update internalLink unit tests

Author: ayoy

org/allPRs.ts

@@ -11,15 +11,19 @@ export const prSize = async () => {
 export const internalLink = async () => {
     const regex = /https:\/\/app.asana.com\/[0-9]\/[0-9]*\/([0-9]*)/
 
+    let hasLink = false;
     // Warn when link to internal task is missing
     for (let bodyLine of danger.github.pr.body.toLowerCase().split(/\n/)) {
         if (bodyLine.includes("task/issue url:")) {
 
             let match = bodyLine.match(regex);
             if (!match || match.length < 2) {
                 fail("Please, don't forget to add a link to the internal task");
+                return;
             }
 
+            hasLink = true;
+
             let taskGID = match[1];
 
             if (process.env.ASANA_ACCESS_TOKEN && process.env.ASANA_PROJECT_ID && process.env.ASANA_PROJECT_NAME) {
@@ -32,10 +36,19 @@ export const internalLink = async () => {
                 let projects = result.data.projects.map( (p) => p.gid );
                 if (!projects.includes(process.env.ASANA_PROJECT_ID)) {
                     fail(`Please ensure that the Asana task is added to ${process.env.ASANA_PROJECT_NAME} project`);
+                    return;
                 }
             }
+
+            if (hasLink) {
+                break;
+            }
         }
     }
+
+    if (!hasLink) {
+        fail("Please, don't forget to add a link to the internal task");
+    }
 }
 
 export const xcodeprojConfiguration = async () => {

tests/internalLink.allPRs.test.ts

@@ -1,6 +1,9 @@
 jest.mock("danger", () => jest.fn())
+jest.mock("Asana", () => jest.fn())
 import danger from 'danger'
+import Asana from 'asana'
 const dm = danger as any;
+const a = Asana as any;
 
 import { internalLink } from '../org/allPRs'
 
@@ -11,17 +14,40 @@ beforeEach(() => {
     dm.danger = {
         github: {
             pr: {
-                body: 'task/issue url: https://app.asana.com/someurl/0001'  
+                body: 'task/issue url: https://app.asana.com/0/0001/0002/f'  
             }
         },
     }
+
+    a.ApiClient = {
+        instance: {
+            authentications: {
+                token: {
+                    accessToken: '1234'
+                }
+            }
+        }
+    }
+
+    a.TasksApi = jest.fn().mockImplementation(() => {
+        return {
+            getTask: jest.fn().mockReturnValue({
+                data: {
+                    projects: [
+                        { gid: '1234' },
+                        { gid: '0001' },
+                    ]
+                }
+            })
+        }
+    })
 })
 
 describe("Internal Asana link test", () => {
     it("does not fail when the description contains a link to Asana", async () => {
         await internalLink()
 
-        expect(dm.warn).not.toHaveBeenCalled()
+        expect(dm.fail).not.toHaveBeenCalled()
     })
 
     it("fails when the description doesn't contain a link to Asana", async () => {
@@ -31,4 +57,40 @@ describe("Internal Asana link test", () => {
 
         expect(dm.fail).toHaveBeenCalledWith("Please, don't forget to add a link to the internal task")
     })
+
+    it("fails when the description contains a malformed link to Asana", async () => {
+        dm.danger.github.pr.body = 'task/issue url: https://app.asana.com/000010002/f' 
+
+        await internalLink();
+        
+        expect(dm.fail).toHaveBeenCalledWith("Please, don't forget to add a link to the internal task")
+    })
+
+    it("fails when the description doesn't contain a line with task/issue URL", async () => {
+        dm.danger.github.pr.body = 'sample random body'
+
+        await internalLink();
+        
+        expect(dm.fail).toHaveBeenCalledWith("Please, don't forget to add a link to the internal task")
+    })
+
+    it("does not fail when the description contains a link to Asana task in a correct project", async () => {
+        process.env.ASANA_ACCESS_TOKEN = '1234'
+        process.env.ASANA_PROJECT_ID = '0001'
+        process.env.ASANA_PROJECT_NAME = 'macOS App Board'
+
+        await internalLink();
+        
+        expect(dm.fail).not.toHaveBeenCalled()
+    })
+
+    it("fails when the description contains a link to Asana task not in a correct project", async () => {
+        process.env.ASANA_ACCESS_TOKEN = '1234'
+        process.env.ASANA_PROJECT_ID = '9999'
+        process.env.ASANA_PROJECT_NAME = 'macOS App Board'
+
+        await internalLink();
+        
+        expect(dm.fail).toHaveBeenCalledWith("Please ensure that the Asana task is added to macOS App Board project")
+    })
 })