Support Windows permission handling in nested iframes in DDG-WebView (#2027)

* Support Windows permission handling in nested iframes in DDG-WebView

* Fix style issues

* move `isDdgWebView` to top level user preferences (windows)

---------

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>

Author: 2 people

injected/src/config-feature.js

@@ -30,6 +30,7 @@ export default class ConfigFeature {
      *   platform: import('./utils.js').Platform,
      *   desktopModeEnabled?: boolean,
      *   forcedZoomEnabled?: boolean,
+     *   isDdgWebView?: boolean,
      *   featureSettings?: Record<string, unknown>,
      *   assets?: import('./content-feature.js').AssetConfig | undefined,
      *   site: import('./content-feature.js').Site,

injected/src/features/windows-permission-usage.js

@@ -17,7 +17,12 @@ export default class WindowsPermissionUsage extends ContentFeature {
             Paused: 'paused',
         };
 
-        const isFrameInsideFrame = window.self !== window.top && window.parent !== window.top;
+        // isDdgWebView is a Windows-specific property injected via userPreferences
+        const isDdgWebView = this.args?.isDdgWebView;
+
+        const isFrameInsideFrameInWebView2 = isDdgWebView
+            ? false // In DDG WebView, we can handle nested frames properly
+            : window.self !== window.top && window.parent !== window.top; // In WebView2, we need to deny permission for nested frames
 
         function windowsPostMessage(name, data) {
             // @ts-expect-error https://app.asana.com/0/1201614831475344/1203979574128023/f
@@ -38,8 +43,8 @@ export default class WindowsPermissionUsage extends ContentFeature {
         // proxy for navigator.geolocation.watchPosition -> show red geolocation indicator
         const watchPositionProxy = new DDGProxy(this, Geolocation.prototype, 'watchPosition', {
             apply(target, thisArg, args) {
-                if (isFrameInsideFrame) {
-                    // we can't communicate with iframes inside iframes -> deny permission instead of putting users at risk
+                if (isFrameInsideFrameInWebView2) {
+                    // we can't communicate with iframes inside iframes in WebView2 -> deny permission instead of putting users at risk
                     throw new DOMException('Permission denied');
                 }
 
@@ -313,8 +318,8 @@ export default class WindowsPermissionUsage extends ContentFeature {
         if (window.MediaDevices) {
             const getUserMediaProxy = new DDGProxy(this, MediaDevices.prototype, 'getUserMedia', {
                 apply(target, thisArg, args) {
-                    if (isFrameInsideFrame) {
-                        // we can't communicate with iframes inside iframes -> deny permission instead of putting users at risk
+                    if (isFrameInsideFrameInWebView2) {
+                        // we can't communicate with iframes inside iframes in WebView2-> deny permission instead of putting users at risk
                         return Promise.reject(new DOMException('Permission denied'));
                     }