Fix lint warnings (#1890)

* Refactor variable names and improve type safety in customizer and build scripts

Co-authored-by: randerson <randerson@duckduckgo.com>

* Don't typecast to any

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: noisysocks

special-pages/index.mjs

@@ -81,9 +81,9 @@ for (const [pageName, injectNames] of Object.entries(support)) {
         errors.push(`${publicDir} does not exist. Each page must have a 'src' directory`);
         continue;
     }
-    for (const [injectName, jobs] of Object.entries(injectNames)) {
+    for (const [injectNameKey, jobs] of Object.entries(injectNames)) {
         // output main dir
-        const buildDir = join(BUILD, injectName);
+        const buildDir = join(BUILD, injectNameKey);
 
         const pageOutputDirectory = join(buildDir, 'pages', pageName);
 
@@ -93,14 +93,14 @@ for (const [pageName, injectNames] of Object.entries(support)) {
                     src: publicDir,
                     dist: join(publicDir, 'dist'),
                     dest: pageOutputDirectory,
-                    injectName,
+                    injectName: injectNameKey,
                 });
             }
             if (job === 'build-js') {
                 const outputDir = join(pageOutputDirectory, 'dist');
                 buildJobs.push({
                     outputDir,
-                    injectName: /** @type {ImportMeta['injectName']} */ (injectName),
+                    injectName: /** @type {ImportMeta['injectName']} */ (injectNameKey),
                     pageName,
                 });
             }

special-pages/pages/new-tab/app/customizer/mocks.js

@@ -119,38 +119,40 @@ export function customizerData() {
     };
 
     if (url.searchParams.has('background')) {
-        const value = url.searchParams.get('background');
-        if (value && value in values.colors) {
+        const backgroundParam = url.searchParams.get('background');
+        if (backgroundParam && backgroundParam in values.colors) {
             customizer.background = {
                 kind: 'color',
-                value: /** @type {import('../../types/new-tab').PredefinedColor} */ (value),
+                value: /** @type {import('../../types/new-tab').PredefinedColor} */ (backgroundParam),
             };
-        } else if (value && value in values.gradients) {
+        } else if (backgroundParam && backgroundParam in values.gradients) {
             customizer.background = {
                 kind: 'gradient',
-                value: /** @type {import('../../types/new-tab').PredefinedGradient} */ (value),
+                value: /** @type {import('../../types/new-tab').PredefinedGradient} */ (backgroundParam),
             };
-        } else if (value && value.startsWith('hex:')) {
-            const hex = value.slice(4);
+        } else if (backgroundParam && backgroundParam.startsWith('hex:')) {
+            const hex = backgroundParam.slice(4);
             if (hex.length === 6 || hex.length === 8) {
+                const value = `#${hex.slice(0, 6)}`;
                 customizer.background = {
                     kind: 'hex',
-                    value: `#${hex.slice(0, 6)}`,
+                    value,
                 };
             } else {
                 console.warn('invalid hex values');
             }
-        } else if (value && value.startsWith('userImage:')) {
-            const image = value.slice(10);
+        } else if (backgroundParam && backgroundParam.startsWith('userImage:')) {
+            const image = backgroundParam.slice(10);
             if (image in values.userImages) {
+                const value = values.userImages[image];
                 customizer.background = {
                     kind: 'userImage',
-                    value: values.userImages[image],
+                    value,
                 };
             } else {
                 console.warn('unknown user image');
             }
-        } else if (value && value === 'default') {
+        } else if (backgroundParam && backgroundParam === 'default') {
             customizer.background = { kind: 'default' };
         }
     }