ep 44 working

Author: drdixit

Core/ValidationException.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Core;
+
+class ValidationException extends \Exception
+{
+    // protected $errors = [];
+    // protected $old = [];
+    // we cant directly access protected properties from outside the class
+    // option 1 make it public
+    // option 2 so we need to create a getter method to access the old data
+    // public function errors()
+    // {
+    //     return $this->errors;
+    // }
+    // another option is declare it public but you can also say readonly
+    // public readonly array $errors;
+    // which means we can assign it only once and we can never update its value
+    public readonly array $errors;
+    public readonly array $old;
+
+    public static function throw($errors, $old)
+    {
+        $instance = new static;
+
+        $instance->errors = $errors;
+        $instance->old = $old;
+
+        throw $instance;
+    }
+
+}

Core/router.php

@@ -112,6 +112,13 @@ public function route($uri, $method)
         $this->abort();
     }
 
+    public function previousUrl()
+    {
+        // option 1 is Router knows previous url
+        // or router can perform a redirect itself
+        return $_SERVER['HTTP_REFERER'];
+    }
+
     protected function abort($code = 404)
     {
         http_response_code($code);

Http/Forms/LoginForm.php

@@ -2,26 +2,59 @@
 
 namespace Http\Forms;
 
+use Core\ValidationException;
 use Core\Validator;
 
 class LoginForm
 {
+    // public $attributes;
     protected $errors = [];
 
-    public function validate($email, $password)
-    {
-        // validate the form inputs.
 
-        if (!Validator::email($email)) {
+    // we have a way to perform validation
+    public function __construct(public array $attributes)
+    {
+        // $this->attributes = $attributes;
+        // or in php 8 we can directly assign the attributes from the constructor
+        // you can also do it like this too
+        // if (!Validator::email($this->attributes['email'])) {
+        if (!Validator::email($attributes['email'])) {
             $this->errors['email'] = 'Please enter a valid email address.';
         }
 
-        if (!Validator::string($password)) {
+        if (!Validator::string($attributes['password'])) {
             $this->errors['password'] = 'Please provide a valid password.';
         }
 
-        // this return $errors array but we want boolean value
-        return empty($this->errors);
+    }
+
+    public static function validate($attributes)
+    {
+        $instance = new static($attributes);
+
+        return $instance->failed() ? $instance->throw() : $instance;
+
+        // these two can be combined
+        // if ($instance->failed()) {
+        //     // throw new ValidationException();
+        //     // ValidationException::throw($instance->errors(), $instance->attributes);
+        //     $instance->throw();
+        // }
+
+        // // what if the form is valid?
+        // return $instance;
+
+    }
+
+    // now we have a way to throw the validation exception
+    public function throw()
+    {
+        ValidationException::throw($this->errors(), $this->attributes);
+    }
+
+    public function failed()
+    {
+        return count($this->errors);
     }
 
     // this is a getter method to access the errors
@@ -31,8 +64,11 @@ public function errors()
         return $this->errors;
     }
 
+    // we have a way to manually add an error to the validation errors list
     public function error($field, $message)
     {
         $this->errors[$field] = $message;
+
+        return $this;
     }
 }

Http/controllers/session/store.php

@@ -4,46 +4,70 @@
 
 // use Core\App;
 use Core\Authenticator;
-use Core\Session;
+// use Core\Session;
+// use Core\ValidationException;
 // use Core\Database;
 // use Core\Validator;
 use Http\Forms\LoginForm;
 
 // $db = App::resolve(Database::class);
 
 // var_dump('I have been posted!');
+// $email = $_POST['email'];
+// $password = $_POST['password'];
+
+// tray catch is move to the public/index.php file
+// try {
+$form = LoginForm::validate($attributes = [
+    'email' => $_POST['email'],
+    'password' => $_POST['password']
+]);
+// } catch (ValidationException $exception) {
+// Session::flash('errors', $exception->errors);
+// Session::flash('old', $exception->old);
 
-$email = $_POST['email'];
-$password = $_POST['password'];
+// return redirect('/login');
+// }
 
-$form = new LoginForm();
+$signedIn = (new Authenticator())
+    ->attempt(
+        $attributes['email'],
+        $attributes['password']
+    );
+
+if (!$signedIn) {
+    $form->error(
+        'email',
+        'No matching account found for that email address and password.'
+    )->throw();
+}
 
-if ($form->validate($email, $password)) {
-    // $auth = new Authenticator();
-    // if you are not passing constructor parameters then you can omit the ()
-    // if ((new Authenticator)->attempt($email, $password)) {
-    if ((new Authenticator())->attempt($email, $password)) {
-        redirect('/');
-    }
+redirect('/');
 
-    $form->error('email', 'No matching account found for that email address and password.');
-}
+// and finally lets reverse it i often like to do my guard clauses before the happy path
+// in this case we are doing the happy path first and then the guard clause
+// if ((new Authenticator())->attempt($attributes['email'], $attributes['password'])) {
+//     redirect('/');
+// }
+
+// $form->error('email', 'No matching account found for that email address and password.')
+//     ->throw();
 
 // $_SESSION['errors'] = $form->errors();
 // we need to expire above thing after one page load
 
 // $_SESSION['_flash']['errors'] = $form->errors();
 
-Session::flash('errors', $form->errors());
+// Session::flash('errors', $form->errors());
 
 // old form data old is really common convention
 // you probably notice this many times there is never a situation where we should manually populate
 // that password input, you always have to reenter it yourself
-Session::flash('old', [
-    'email' => $_POST['email']
-]);
+// Session::flash('old', [
+//     'email' => $_POST['email']
+// ]);
 
-return redirect('/login');
+// return redirect('/login');
 
 // return view('session/create.view.php', [
 //     'errors' => $form->errors()

public/index.php

@@ -1,6 +1,7 @@
 <?php
 
 use Core\Session;
+use Core\ValidationException;
 
 session_start();
 
@@ -22,7 +23,25 @@
 $uri = parse_url($_SERVER['REQUEST_URI'])['path'];
 $method = $_POST['_method'] ?? $_SERVER['REQUEST_METHOD'];
 
-$router->route($uri, $method);
+try {
+    // try to the route to the controller
+    $router->route($uri, $method);
+} catch (ValidationException $exception) {
+    // but catch any validation exceptions that might be thrown
+    // and here in a single place not every controller
+    // but a single place we can flash the errors and old data
+    // and then redirect back
+    // thats one way we can solve this problem
+    // dd($_SERVER);
+    // $_SERVER['HTTP_REFERER']
+    Session::flash('errors', $exception->errors);
+    Session::flash('old', $exception->old);
+
+    // this needs to be dynamic
+    // return redirect('/login');
+    return redirect($router->previousUrl());
+}
+
 
 // right here we can clear out any _flash session data
 // later we will refactor this and organize it better