Skip to content

Conversation

@jannon
Copy link

@jannon jannon commented Oct 22, 2015

This is a fix for #274. All tests pass so unless the author of f5a1a49 can provide a failing test, I think the custom application model support should be restored. This is really a bug that completely breaks custom application model use in registration

@outsbart
Copy link
Contributor

@jannon could you please provide a failing test reproducing #274?

@jannon
Copy link
Author

jannon commented Oct 22, 2015

Ah, knew I forgot something. Sure thing.

@jannon
Copy link
Author

jannon commented Oct 22, 2015

actually, we need only use the TestApplication model in the settings and the existing application registration test will catch the failure

@synasius
Copy link
Contributor

This can't be merged because the get_application_model at module level raises the exception described in #151.
BTW, I pushed a proper solution which I'll merge asap. See #323

@synasius synasius closed this Nov 20, 2015
@synasius synasius added this to the 0.10.0 milestone Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants