Prevent the tests/migrations directory from getting packaged #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 32 32
Lines 1806 1806
=======================================
Hits 1745 1745
Misses 61 61 Continue to review full report at Codecov.
|
n2ygk
previously requested changes
Feb 16, 2022
Contributor
n2ygk
left a comment
n2ygk
left a comment
There was a problem hiding this comment.
Thanks for this! No need for the CHANGELOG update.
Simply excluding "tests" is not enough to prevent subpackages from also being excluded. If a wildcard is provided to "find_packages(exclude=", it will only match a single hierarchy level. Without this, a directory "site-packages/tests/migrations" gets created upon package install.
brianhelba
force-pushed
the
exclude-tests
branch
from
e9c0e5e to
3871085
Compare
n2ygk
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply excluding
testsis not enough to prevent subpackages from also being excluded. If a wildcard is provided tofind_packages(exclude=, it will only match a single hierarchy level.Without this, a directory
site-packages/tests/migrationsgets created upon package install.Checklist
unit-test addeddocumentation updatedCHANGELOG.mdupdated (only for user relevant changes)AUTHORS