From 0e63e27122f207aee52d33dd513370589336752e Mon Sep 17 00:00:00 2001 From: Divit Bui Date: Fri, 14 Dec 2018 17:02:33 +0000 Subject: [PATCH 1/2] Update filter in Controller --- .../springboot/application/controller/ApiRestController.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/controller/ApiRestController.java b/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/controller/ApiRestController.java index c82cf40..9f88f6f 100644 --- a/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/controller/ApiRestController.java +++ b/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/controller/ApiRestController.java @@ -1,6 +1,7 @@ package com.divit.springboot.application.controller; import java.util.List; +import java.util.stream.Collectors; import org.springframework.http.ResponseEntity; import org.springframework.util.StringUtils; @@ -27,7 +28,9 @@ public ResponseEntity fetchCandidates(@RequestParam(value = "skill", required List candidateList = CandidatesUtil.getCandidates(); if (!StringUtils.isEmpty(skill)) { // Filter by skill - candidateList.removeIf((candidate) -> !candidate.getSkillsSet().contains(skill.toLowerCase())); + return ResponseEntity.ok(candidateList.stream() + .filter(candidate -> candidate.getSkillsSet().contains(skill.toLowerCase())) + .collect(Collectors.toList())); } return ResponseEntity.ok(candidateList); From 01ebf2b0d68b2a106f7cf9c8e1c244b198317218 Mon Sep 17 00:00:00 2001 From: Divit Bui Date: Fri, 14 Dec 2018 17:02:42 +0000 Subject: [PATCH 2/2] Add java doc to util --- .../divit/springboot/application/util/CandidatesUtil.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/util/CandidatesUtil.java b/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/util/CandidatesUtil.java index 71432bd..bb4af14 100644 --- a/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/util/CandidatesUtil.java +++ b/com.divit.spring-boot-simple-rest-api/src/main/java/com/divit/springboot/application/util/CandidatesUtil.java @@ -12,6 +12,12 @@ public final class CandidatesUtil { private CandidatesUtil() { } + /** + * + * Method to help us get dummy data + * + * @return list of candidates + */ public static List getCandidates() { List candidateList = new ArrayList<>(); candidateList.add(new Candidate("John", 2, new HashSet(Arrays.asList("java", "c#", "c++", "golang"))));