Add maven shell script formatting support via shfmt #1998
Conversation
|
|
||
| import com.diffplug.spotless.maven.MavenIntegrationHarness; | ||
|
|
||
| @Disabled // Disabled due to GHA not having shfmt |
There was a problem hiding this comment.
Please let me know if I missed some detail that enables these types of formatters (ones that need to shell out) to run in GitHub action workflows. I'd be happy to add whatever is needed to get this to run in GHA.
There was a problem hiding this comment.
I replaced @Disabled with @ShfmtTest. If you run gradlew test these tests will not run. They only run when you run ./gradlew testShfmt to run them.
If you want them to run on CI, you should add them with the npm test
spotless/.github/workflows/ci.yml
Lines 79 to 81 in 797a665
- change it to
./gradlew testNpm testShfmt
The only tricky part is getting shfmt onto the CI runner. Not that hard though. Feel free to open a PR for it and mess around.
There was a problem hiding this comment.
Perfect! Thank you for the clarification.
tbcrawford
changed the title
…ag was being simultaneously excluded and included.
|
Published in |
This adds Maven support for shfmt and addresses #1567. This is a follow up to #1994. Closes #1567 #1776