Skip to content

Commit 491cad5

Browse files
committed
Clean up BaseKotlinExtension
1 parent 4597085 commit 491cad5

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/BaseKotlinExtension.java

+17-18
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,10 @@ public KtfmtConfig ktfmt(String version) {
7070
protected abstract boolean isScript();
7171

7272
public class DiktatConfig {
73-
7473
private final String version;
7574
private FileSignature config;
7675

77-
DiktatConfig(String version) {
76+
private DiktatConfig(String version) {
7877
Objects.requireNonNull(version, "version");
7978
this.version = version;
8079
addStep(createStep());
@@ -97,24 +96,18 @@ private FormatterStep createStep() {
9796
}
9897

9998
public class KtfmtConfig {
100-
final String version;
101-
KtfmtStep.Style style;
102-
KtfmtStep.KtfmtFormattingOptions options;
99+
private final String version;
100+
private KtfmtStep.Style style;
101+
private KtfmtStep.KtfmtFormattingOptions options;
103102

104103
private final ConfigurableStyle configurableStyle = new ConfigurableStyle();
105104

106-
KtfmtConfig(String version) {
105+
private KtfmtConfig(String version) {
107106
Objects.requireNonNull(version);
108107
this.version = Objects.requireNonNull(version);
109108
addStep(createStep());
110109
}
111110

112-
private ConfigurableStyle style(KtfmtStep.Style style) {
113-
this.style = style;
114-
replaceStep(createStep());
115-
return configurableStyle;
116-
}
117-
118111
public ConfigurableStyle dropboxStyle() {
119112
return style(KtfmtStep.Style.DROPBOX);
120113
}
@@ -131,13 +124,18 @@ public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfigur
131124
this.configurableStyle.configure(optionsConfiguration);
132125
}
133126

127+
private ConfigurableStyle style(KtfmtStep.Style style) {
128+
this.style = style;
129+
replaceStep(createStep());
130+
return configurableStyle;
131+
}
132+
134133
private FormatterStep createStep() {
135134
return KtfmtStep.create(version, provisioner(), style, options);
136135
}
137136

138137
public class ConfigurableStyle {
139-
140-
public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfiguration) {
138+
private void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfiguration) {
141139
KtfmtStep.KtfmtFormattingOptions ktfmtFormattingOptions = new KtfmtStep.KtfmtFormattingOptions();
142140
optionsConfiguration.accept(ktfmtFormattingOptions);
143141
options = ktfmtFormattingOptions;
@@ -147,26 +145,27 @@ public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfigur
147145
}
148146

149147
public class KtlintConfig {
150-
151148
private final String version;
152149
@Nullable
153150
private FileSignature editorConfigPath;
154151
private Map<String, String> userData;
155152
private Map<String, Object> editorConfigOverride;
156153

157-
KtlintConfig(String version, Map<String, String> config,
154+
private KtlintConfig(
155+
String version,
156+
Map<String, String> userData,
158157
Map<String, Object> editorConfigOverride) throws IOException {
159158
Objects.requireNonNull(version);
160159
File defaultEditorConfig = getProject().getRootProject().file(".editorconfig");
161160
FileSignature editorConfigPath = defaultEditorConfig.exists() ? FileSignature.signAsList(defaultEditorConfig) : null;
162161
this.version = version;
163162
this.editorConfigPath = editorConfigPath;
164-
this.userData = config;
163+
this.userData = userData;
165164
this.editorConfigOverride = editorConfigOverride;
166165
addStep(createStep());
167166
}
168167

169-
public KtlintConfig setEditorConfigPath(Object editorConfigPath) throws IOException {
168+
public KtlintConfig setEditorConfigPath(@Nullable Object editorConfigPath) throws IOException {
170169
if (editorConfigPath == null) {
171170
this.editorConfigPath = null;
172171
} else {

0 commit comments

Comments
 (0)