Remove need for ActorQueueSynchronization #40
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 657 666 +9
=========================================
+ Hits 657 666 +9
|
dfed
changed the title
Sources/AsyncQueue/ActorQueue.swift
Outdated
| /// | ||
| /// - Parameter actor: The actor on which the queue's task will execute. This parameter is not retained by the receiver. | ||
| /// - Warning: Calling this method more than once will result in an assertion failure. | ||
| /// - Precondition: Calling this method more than once will result in a precondition failure. |
There was a problem hiding this comment.
Now that we're kicking off the stream execution here, precondition feels appropriate.
Sources/AsyncQueue/ActorQueue.swift
Outdated
| actor.execute { [taskStream] _ in | ||
| func beginExecuting( | ||
| _ operation: sending @escaping (isolated ActorType) async -> Void, | ||
| in context: isolated ActorType | ||
| ) { | ||
| // In Swift 6, a `Task` enqueued from an actor begins executing immediately on that actor. | ||
| // Since we're running on our actor's context due to the isolated parmater, we can just dispatch a Task to get first-enqueued-first-start task execution. | ||
| Task { | ||
| await operation(context) | ||
| } | ||
| } | ||
|
|
||
| for await actorTask in taskStream { | ||
| await beginExecuting( | ||
| actorTask.task, | ||
| in: actorTask.executionContext | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
this entire closure executes within the actor context!
Sources/AsyncQueue/ActorQueue.swift
Outdated
| extension Actor { | ||
| nonisolated | ||
| func execute( | ||
| _ task: @escaping @Sendable (isolated Self?) async -> Void |
There was a problem hiding this comment.
a bit nuts, but using (isolated Self?) enables us to isolate the closure to the actor's context without retaining the actor.
Sources/AsyncQueue/ActorQueue.swift
Outdated
| } | ||
|
|
||
| for await actorTask in taskStream { | ||
| await beginExecuting( |
There was a problem hiding this comment.
we need to await here despite the fact that we're already isolated to the context because the compiler does not have a guarantee that actorTask.executionContext === actor`. In practice, these are always the same and therefore we do not suspend here.
dfed
changed the title
We don't need to bounce through a global queue in order to ensure FIFS (first-enqueued-first-start) behavior in our ActorQueue. Instead, we just can make the async for loop await switching to the ActorType's context.
This PR is unlikely to affect performance. This PR should make this code a bit easier to follow, however.