init #2
Merged
init #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improvement
setup instruction
Docs/improve
py install step and more py setup
py packaging and coverage
coverage test
diego-deriv
approved these changes
Oct 29, 2021
|
LGTM |
shantanu-deriv
approved these changes
Nov 1, 2021
python-deriv-api/doc_improve
chylli-deriv
commented
Nov 6, 2021
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
Contributor
Author
There was a problem hiding this comment.
We can ask other again to confirm this license .
chylli-deriv
commented
Nov 6, 2021
Makefile
Outdated
| build: | ||
| pip3 install build && python3 -m build | ||
| coverage: | ||
| pipenv run coverage run --source deriv_api -m pytest && pipenv run coverage report -m No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| pipenv run coverage run --source deriv_api -m pytest && pipenv run coverage report -m | |
| pipenv run coverage run --source deriv_api -m pytest && pipenv run coverage report -m | |
chylli-deriv
commented
Nov 6, 2021
Pipfile
Outdated
Comment on lines
2
to
4
| url = "https://pypi.org/simple" | ||
| verify_ssl = true | ||
| name = "pypi" |
Contributor
Author
There was a problem hiding this comment.
I think this section should be updated.
Suggested change
| url = "https://pypi.org/simple" | |
| verify_ssl = true | |
| name = "pypi" | |
| url = "https://github.com/binary-com/python-deriv-api" | |
| verify_ssl = true | |
| name = "python-driv-api" |
chylli-deriv
commented
Nov 6, 2021
| coverage = "===4.5.4" | ||
|
|
||
| [requires] | ||
| python_version = "3.9.6" |
Contributor
Author
There was a problem hiding this comment.
Can we add a comment to explain why we need 3.9.6 ?
like there is a bug in 'websockets' package when python is 3.9.7. Hope it will be fixed in 3.9.8
Contributor
There was a problem hiding this comment.
Added a note in README
chylli-deriv
commented
Nov 6, 2021
| Use this all-in-one python library to set up and make your app running or you can extend it. | ||
|
|
||
| ### Requirement | ||
| Python (3.9.6 or higher is recommended) and pip3 |
Contributor
Author
There was a problem hiding this comment.
Please exclude 3.9.7 here.
chylli-deriv
commented
Nov 6, 2021
| @@ -0,0 +1,14 @@ | |||
| """ | |||
| .. include:: ../README.md | |||
Contributor
Author
There was a problem hiding this comment.
wow, can here doc include md file ?
company name and gitignore update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.