Add middleware #10
Add middleware #10
Conversation
deriv_api/deriv_api.py
Outdated
| return send_is_called | ||
| return response | ||
|
|
||
| def _call_middleware(self, name: str, args: dict) -> Union[None,dict]: |
There was a problem hiding this comment.
refactor it to the separate class?
There was a problem hiding this comment.
How ? Could you please give me soem psudo-code ?
There was a problem hiding this comment.
I mean write a new middleware class and add this method there
There was a problem hiding this comment.
ok got your idea.
Let me do it.
But when I implement this feature, in js version I didn't find any place that this feature is used. I suspect it is useless. I even don't know I should keep this feature or not :(
There was a problem hiding this comment.
middlewares are useful when used stack-like manner, allowing you to perform actions downstream then filter and manipulate the response upstream. This means in a small workflow like this is not much need but keeping in mind the future, its okay
chylli-deriv
force-pushed
the
add_middleware
branch
from
dfb77ef to
005a2c5
Compare
deriv_api/deriv_api.py
Outdated
| 'deriv_api.deriv_api.DerivAPI.wsconnection': False, | ||
| 'deriv_api.deriv_api.DerivAPI.storage': False | ||
| 'deriv_api.deriv_api.DerivAPI.storage': False, | ||
| 'deriv_api.deriv_api.DerivAPI._call_middleware': False |
There was a problem hiding this comment.
Why the naming convention is different from others? Why not use deriv_api.deriv_api.DerivAPI.middleware
There was a problem hiding this comment.
Sorry this is the old name that should be deleted.
will drop it.
3 participants
No description provided.