JSON format fix

Author: dercoder

src/Message/FetchTransactionRequest.php

@@ -23,14 +23,14 @@ public function getData()
         if ($transactionId = $this->getTransactionId()) {
 
             return array(
-                'id'      => $transactionId,
+                'id'      => (string) $transactionId,
                 'refType' => 'merchantRefId'
             );
 
         } elseif ($transactionReference = $this->getTransactionReference()) {
 
             return array(
-                'id' => $transactionReference
+                'id' => (string) $transactionReference
             );
 
         } else {

src/Message/PayoutRequest.php

@@ -46,14 +46,14 @@ public function getData()
 
         return array(
             'payeeProfile' => array(
-                'email' => $this->getEmail()
+                'email' => (string) $this->getEmail()
             ),
             'transaction'  => array(
-                'merchantRefId' => $this->getTransactionId(),
-                'amount'        => $this->getAmountInteger(),
-                'currency'      => $this->getCurrency(),
+                'merchantRefId' => (string) $this->getTransactionId(),
+                'amount'        => (int) $this->getAmountInteger(),
+                'currency'      => (string) $this->getCurrency(),
             ),
-            'message'      => $this->getDescription()
+            'message'      => (string) $this->getDescription()
         );
     }
 

src/Message/PurchaseRequest.php

@@ -65,14 +65,14 @@ public function getData()
         return array(
             'paymentMethod'    => array(
                 'type'  => 'neteller',
-                'value' => $this->getEmail()
+                'value' => (string) $this->getEmail()
             ),
             'transaction'      => array(
-                'merchantRefId' => $this->getTransactionId(),
-                'amount'        => $this->getAmountInteger(),
-                'currency'      => $this->getCurrency(),
+                'merchantRefId' => (string) $this->getTransactionId(),
+                'amount'        => (int) $this->getAmountInteger(),
+                'currency'      => (string) $this->getCurrency(),
             ),
-            'verificationCode' => $this->getVerificationCode()
+            'verificationCode' => (string) $this->getVerificationCode()
         );
     }
 

tests/Omnipay/Neteller/Message/FetchTransactionRequestTest.php

@@ -15,26 +15,26 @@ public function setUp()
         parent::setUp();
         $this->request = new FetchTransactionRequest($this->getHttpClient(), $this->getHttpRequest());
         $this->request->initialize(array(
-            'transactionId' => 'TX4567890'
+            'transactionId' => 4567890
         ));
     }
 
     public function testGetData()
     {
         $this->request->initialize(array(
-            'transactionId' => 'TX4567890'
+            'transactionId' => 4567890
         ));
 
         $data = $this->request->getData();
-        $this->assertSame('TX4567890', $data['id']);
+        $this->assertSame('4567890', $data['id']);
         $this->assertSame('merchantRefId', $data['refType']);
 
         $this->request->initialize(array(
-            'transactionReference' => 'RF4567890'
+            'transactionReference' => 4567890
         ));
 
         $data = $this->request->getData();
-        $this->assertSame('RF4567890', $data['id']);
+        $this->assertSame('4567890', $data['id']);
         $this->assertArrayNotHasKey('refType', $data);
 
         $this->request->initialize(array());

tests/Omnipay/Neteller/Message/PayoutRequestTest.php

@@ -16,10 +16,10 @@ public function setUp()
         $this->request = new PayoutRequest($this->getHttpClient(), $this->getHttpRequest());
         $this->request->initialize(array(
             'email'            => 'netellertest_USD@neteller.com',
-            'verificationCode' => '270955',
-            'transactionId'    => 'TX4567890',
+            'verificationCode' => 270955,
+            'transactionId'    => 4567890,
             'description'      => 'Free Text Description',
-            'amount'           => '12.34',
+            'amount'           => 12.34,
             'currency'         => 'USD'
         ));
     }
@@ -28,7 +28,7 @@ public function testGetData()
     {
         $data = $this->request->getData();
         $this->assertSame('netellertest_USD@neteller.com', $data['payeeProfile']['email']);
-        $this->assertSame('TX4567890', $data['transaction']['merchantRefId']);
+        $this->assertSame('4567890', $data['transaction']['merchantRefId']);
         $this->assertSame(1234, $data['transaction']['amount']);
         $this->assertSame('USD', $data['transaction']['currency']);
         $this->assertSame('Free Text Description', $data['message']);

tests/Omnipay/Neteller/Message/PurchaseRequestTest.php

@@ -16,9 +16,9 @@ public function setUp()
         $this->request = new PurchaseRequest($this->getHttpClient(), $this->getHttpRequest());
         $this->request->initialize(array(
             'email'            => 'netellertest_USD@neteller.com',
-            'verificationCode' => '270955',
-            'transactionId'    => 'TX4567890',
-            'amount'           => '12.34',
+            'verificationCode' => 270955,
+            'transactionId'    => 4567890,
+            'amount'           => 12.34,
             'currency'         => 'USD'
         ));
     }
@@ -28,7 +28,7 @@ public function testGetData()
         $data = $this->request->getData();
         $this->assertSame('neteller', $data['paymentMethod']['type']);
         $this->assertSame('netellertest_USD@neteller.com', $data['paymentMethod']['value']);
-        $this->assertSame('TX4567890', $data['transaction']['merchantRefId']);
+        $this->assertSame('4567890', $data['transaction']['merchantRefId']);
         $this->assertSame(1234, $data['transaction']['amount']);
         $this->assertSame('USD', $data['transaction']['currency']);
         $this->assertSame('270955', $data['verificationCode']);