-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: add bcrypt
and argon2
support to std/crypto
#5899
Comments
My immediate impression is that a new API isn't needed. Rather, we could add documentation to |
Thanks for the comment @iuioiua, although I have to admit I don’t quite understand. I can’t see how this could be achieved using the current |
FYI, I have already done some of the prework for supporting password hashing in the crypto module in stdext. This can be moved to std if the team wants to add support for password hashing in the future 💪🏻 |
With the introduction of Deno 2.1 and direct Wasm imports, does this change anything here? |
We already use wasm in std/crypto implementation https://github.com/denoland/std/tree/main/crypto/_wasm Do you suggest adding |
@kt3k A password specific hashing API would make for a nice developer experience, but perhaps something that could come later, building on top of digest API support. |
bcrypt
and argon2
support to std/crypto
Is there any progress on the argon2 support? That would be great for modern webapps opting to choose deno. |
Is your feature request related to a problem? Please describe.
Thoughts on supporting something such as
Bun.password
- https://bun.sh/docs/api/hashing ?Describe the solution you'd like
Perhaps std/crypto would be a good place to support something similar? Wrapping the native Rust implementation(s) via WASM.
Describe alternatives you've considered
Currently to use something like argon2 or bcrypt with Deno, you must find and trust a third-party developers wrapper, or attempt bindings yourself. Providing this as part of std/crypto, a trusted dependancy, could help to improve security for those needing password hashing, and improve ease of implementation.
Thanks!
The text was updated successfully, but these errors were encountered: