Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to-do: make @std/http/file-server compatible with deno serve --parallel #5681

Open
iuioiua opened this issue Aug 15, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request http PR welcome A pull request for this issue would be welcome

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Aug 15, 2024

deno serve --parallel was implemented in denoland/deno#24920. @std/http/file-server should be made to use this sub-command and take advantage of --parallel. Benchmarks would also be great.

@iuioiua iuioiua added enhancement New feature or request http PR welcome A pull request for this issue would be welcome labels Aug 15, 2024
@kt3k
Copy link
Member

kt3k commented Aug 15, 2024

Is there a way to detect if the script is executed with deno serve?

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 22, 2024

We discussed this offline and we'll be creating a @std/http/x-file-server module which will be marked as unstable at least until --parallel is stable.

@iuioiua
Copy link
Contributor Author

iuioiua commented Aug 23, 2024

Talking with David, it might be worth adding a parallel: boolean option to Deno.serve() instead. Then, we could just add a --parallel flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request http PR welcome A pull request for this issue would be welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants