feat(fs): add lookPath function #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to add some tests, especially for Windows |
|
@wperron Let me know if I can help validate anything on Windows. |
kt3k
reviewed
Jul 27, 2021
| async function chkStat(file: string) { | ||
| const s = await Deno.stat(file); | ||
| if (s.isDirectory) { | ||
| throw new Deno.errors.PermissionDenied(file); |
There was a problem hiding this comment.
Maybe better to give more descriptive error message? somthing like ${file} is a directory
Port of the [lookPath][1] function from Go's exec package. Fixes denoland#1056. [1]https://pkg.go.dev/os/exec#example-LookPath
wperron
force-pushed
the
feature/lookpath
branch
from
9924f91 to
87795a3
Compare
|
|
|
This is stale and not close to landing. I'm going to close it for now, if anyone feels like picking it up, feel free to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of the [lookPath][1] function from Go's exec package. Fixes #1056.
[1]https://pkg.go.dev/os/exec#example-LookPath