Skip to content

Commit 49e3a5e

Browse files
committed
Add missing assign hook for GUC checkpoint_completion_target
This is wrong since 88e9823, that has switched the WAL sizing configuration from checkpoint_segments to min_wal_size and max_wal_size. This missed the recalculation of the internal value of the internal "CheckPointSegments", that works as a mapping of the old GUC checkpoint_segments, on reload, for example, and it controls the timing of checkpoints depending on the volume of WAL generated. Most users tend to leave checkpoint_completion_target at 0.9 to smooth the I/O workload, which is why I guess this has gone unnoticed for so long, still it can be useful to tweak and reload the value dynamically in some cases to control the timing of checkpoints. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com Backpatch-through: 11
1 parent 1391916 commit 49e3a5e

File tree

1 file changed

+1
-1
lines changed
  • src/backend/utils/misc

1 file changed

+1
-1
lines changed

src/backend/utils/misc/guc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3909,7 +3909,7 @@ static struct config_real ConfigureNamesReal[] =
39093909
},
39103910
&CheckPointCompletionTarget,
39113911
0.9, 0.0, 1.0,
3912-
NULL, NULL, NULL
3912+
NULL, assign_checkpoint_completion_target, NULL
39133913
},
39143914

39153915
{

0 commit comments

Comments
 (0)