More updates based on PR feedback

Author: Andrew Theis

Sources/PostgreSQL/Database/PostgreSQLDatabaseConfig.swift

@@ -29,17 +29,17 @@ public struct PostgreSQLDatabaseConfig {
     public let transportConfig: PostgreSQLTransportConfig
 
     /// Creates a new `PostgreSQLDatabaseConfig`.
-    public init(hostname: String, port: Int = 5432, username: String, database: String? = nil, password: String? = nil, transportConfig: PostgreSQLTransportConfig = .cleartext) {
+    public init(hostname: String, port: Int = 5432, username: String, database: String? = nil, password: String? = nil, transport: PostgreSQLTransportConfig = .cleartext) {
         self.hostname = hostname
         self.port = port
         self.username = username
         self.database = database
         self.password = password
-        self.transportConfig = transportConfig
+        self.transportConfig = transport
     }
 
     /// Creates a `PostgreSQLDatabaseConfig` frome a connection string.
-    public init(url urlString: String, transportConfig: PostgreSQLTransportConfig = .cleartext) throws {
+    public init(url urlString: String, transport: PostgreSQLTransportConfig = .cleartext) throws {
         guard let url = URL(string: urlString),
             let hostname = url.host,
             let port = url.port,
@@ -64,6 +64,6 @@ public struct PostgreSQLDatabaseConfig {
             self.database = database
         }
         self.password = url.password
-        self.transportConfig = transportConfig
+        self.transportConfig = transport
     }
 }

Sources/PostgreSQL/Message/PostgreSQLSSLSupportResponse.swift

@@ -1,7 +1,7 @@
 import Core
 
-/// Response given after sending a PostgreSQLSSLSupportRequest
-/// For more info, see https://www.postgresql.org/docs/10/static/protocol-flow.html#id-1.10.5.7.11
+/// Response given after sending a `PostgreSQLSSLSupportRequest`.
+/// See https://www.postgresql.org/docs/10/static/protocol-flow.html#id-1.10.5.7.11 for more info.
 enum PostgreSQLSSLSupportResponse: UInt8, Decodable {
     /// The server supports SSL (char S).
     case supported = 0x53

Tests/PostgreSQLTests/PostgreSQLConnectionTests.swift

@@ -467,7 +467,7 @@ extension PostgreSQLConnection {
         #endif
     }
 
-    /// Creates a test event loop and psql client over ssl
+    /// Creates a test event loop and psql client over ssl.
     static func makeTest(transport: PostgreSQLTransportConfig) throws -> PostgreSQLConnection {
         #if Xcode
         return try _makeTest(hostname: self.dockerMachineHostname, port: 5433, transport: transport)
@@ -480,7 +480,7 @@ extension PostgreSQLConnection {
         let group = MultiThreadedEventLoopGroup(numThreads: 1)
         let client = try PostgreSQLConnection.connect(hostname: hostname, port: port, transport: transport, on: group) { error in
             XCTFail("\(error)")
-            }.wait()
+        }.wait()
         _ = try client.authenticate(username: "vapor_username", database: "vapor_database", password: password).wait()
         return client
     }