Bug #30556595 FAILING ASSERTION: !CURSOR->INDEX->IS_COMMITTED() ON

sachinagarwal1111 · sachinagarwal1111 · commit fba1f0f17e7f · 2021-05-19T14:31:19.000+05:30
TABLE WITH GCOLS

Post-push test-case fix.

RB: 26149
Reviewed by : Debarun Banerjee &lt;debarun.banerjee@oracle.com&gt;
diff --git a/mysql-test/suite/innodb/r/virtual_debug.result b/mysql-test/suite/innodb/r/virtual_debug.result
@@ -445,3 +445,101 @@ gc
 -1
 COMMIT;
 DROP TABLE t2;
+#
+# Bug #30556595  FAILING ASSERTION: !CURSOR->INDEX->IS_COMMITTED()
+# ON TABLE WITH GCOLS
+#
+# Testcase-1
+CREATE TABLE t (pid int PRIMARY KEY,
+uid int,
+vid int AS (uid) VIRTUAL);
+# Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+# Insert a record to generate an insert row log for the new index.
+# LOG-1 idx_vid : INSERT [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+# Update the record changing PK. It should generate 2 row logs for the new index.
+# LOG-2 idx_vid : DELETE [10, 1]
+# LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SELECT * FROM t;
+pid	uid	vid
+2	10	10
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+# Insert a record to re-use the delete marked record in idx_vid [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+SELECT * FROM t;
+pid	uid	vid
+1	10	10
+2	10	10
+DROP TABLE t;
+# Testcase-2
+CREATE TABLE t (pid int PRIMARY KEY,
+uid int,
+vid int AS (uid) VIRTUAL);
+# Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+# Start transaction
+BEGIN;
+# Insert a record to generate an insert row log for the new index.
+# LOG-1 idx_vid : INSERT [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+# Update the record changing PK. It should generate 2 row logs for the new index.
+# LOG-2 idx_vid : DELETE [10, 1]
+# LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SELECT * FROM t;
+pid	uid	vid
+2	10	10
+# Rollback transaction
+# LOG-4 idx_vid : DELETE [10, 2]
+# LOG-5 idx_vid : INSERT [10, 1]
+# LOG-6 idx_vid : DELETE [10, 1]
+ROLLBACK;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+# Insert a record to check valid entry in idx_vid [NULL, 1]
+INSERT INTO t(pid) VALUES (1);
+SELECT * FROM t;
+pid	uid	vid
+1	NULL	NULL
+DROP TABLE t;
+# Testcase-3
+CREATE TABLE t (pid int PRIMARY KEY,
+uid int,
+vid int AS (uid) VIRTUAL);
+INSERT INTO t(pid, uid) VALUES (1,10);
+# Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+# Update the record changing PK. It should generate 2 row logs for the new index.
+# LOG-2 idx_vid : DELETE [10, 1]
+# LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+# Read [2, 10, 10] row using idx_vid index key.
+select * from t where VID=10;
+pid	uid	vid
+2	10	10
+DROP TABLE t;
+# Testcase-4
+CREATE TABLE t (pid int PRIMARY KEY,
+uid int,
+vid int AS (uid) VIRTUAL);
+INSERT INTO t(pid, uid) VALUES (1,10);
+# Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+# Update the record changing PK. It should generate 2 row logs for the new index.
+# LOG-2 idx_vid : DELETE [10, 1]
+# LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+# Delete a record.
+delete from t limit 1;
+DROP TABLE t;
diff --git a/mysql-test/suite/innodb/r/virtual_index.result b/mysql-test/suite/innodb/r/virtual_index.result
@@ -211,101 +211,3 @@ t1	CREATE TABLE `t1` (
   KEY `n` (`col2`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
 DROP TABLE t1;
-#
-# Bug #30556595  FAILING ASSERTION: !CURSOR->INDEX->IS_COMMITTED()
-# ON TABLE WITH GCOLS
-#
-# Testcase-1
-CREATE TABLE t (pid int PRIMARY KEY,
-uid int,
-vid int AS (uid) VIRTUAL);
-# Create index on virtual column and stop before applying row logs.
-SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
-ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
-SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
-# Insert a record to generate an insert row log for the new index.
-# LOG-1 idx_vid : INSERT [10, 1]
-INSERT INTO t(pid, uid) VALUES (1,10);
-# Update the record changing PK. It should generate 2 row logs for the new index.
-# LOG-2 idx_vid : DELETE [10, 1]
-# LOG-3 idx_vid : INSERT [10, 2]
-UPDATE t SET pid = 2 WHERE pid = 1;
-SELECT * FROM t;
-pid	uid	vid
-2	10	10
-SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
-# Insert a record to re-use the delete marked record in idx_vid [10, 1]
-INSERT INTO t(pid, uid) VALUES (1,10);
-SELECT * FROM t;
-pid	uid	vid
-1	10	10
-2	10	10
-DROP TABLE t;
-# Testcase-2
-CREATE TABLE t (pid int PRIMARY KEY,
-uid int,
-vid int AS (uid) VIRTUAL);
-# Create index on virtual column and stop before applying row logs.
-SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
-ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
-SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
-# Start transaction
-BEGIN;
-# Insert a record to generate an insert row log for the new index.
-# LOG-1 idx_vid : INSERT [10, 1]
-INSERT INTO t(pid, uid) VALUES (1,10);
-# Update the record changing PK. It should generate 2 row logs for the new index.
-# LOG-2 idx_vid : DELETE [10, 1]
-# LOG-3 idx_vid : INSERT [10, 2]
-UPDATE t SET pid = 2 WHERE pid = 1;
-SELECT * FROM t;
-pid	uid	vid
-2	10	10
-# Rollback transaction
-# LOG-4 idx_vid : DELETE [10, 2]
-# LOG-5 idx_vid : INSERT [10, 1]
-# LOG-6 idx_vid : DELETE [10, 1]
-ROLLBACK;
-SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
-# Insert a record to check valid entry in idx_vid [NULL, 1]
-INSERT INTO t(pid) VALUES (1);
-SELECT * FROM t;
-pid	uid	vid
-1	NULL	NULL
-DROP TABLE t;
-# Testcase-3
-CREATE TABLE t (pid int PRIMARY KEY,
-uid int,
-vid int AS (uid) VIRTUAL);
-INSERT INTO t(pid, uid) VALUES (1,10);
-# Create index on virtual column and stop before applying row logs.
-SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
-ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
-SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
-# Update the record changing PK. It should generate 2 row logs for the new index.
-# LOG-2 idx_vid : DELETE [10, 1]
-# LOG-3 idx_vid : INSERT [10, 2]
-UPDATE t SET pid = 2 WHERE pid = 1;
-SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
-# Read [2, 10, 10] row using idx_vid index key.
-select * from t where VID=10;
-pid	uid	vid
-2	10	10
-DROP TABLE t;
-# Testcase-4
-CREATE TABLE t (pid int PRIMARY KEY,
-uid int,
-vid int AS (uid) VIRTUAL);
-INSERT INTO t(pid, uid) VALUES (1,10);
-# Create index on virtual column and stop before applying row logs.
-SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
-ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace;
-SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
-# Update the record changing PK. It should generate 2 row logs for the new index.
-# LOG-2 idx_vid : DELETE [10, 1]
-# LOG-3 idx_vid : INSERT [10, 2]
-UPDATE t SET pid = 2 WHERE pid = 1;
-SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
-# Delete a record.
-delete from t limit 1;
-DROP TABLE t;
diff --git a/mysql-test/suite/innodb/t/virtual_debug.test b/mysql-test/suite/innodb/t/virtual_debug.test
@@ -542,3 +542,120 @@ CONNECTION default;
 COMMIT;
 
 DROP TABLE t2;
+
+--echo #
+--echo # Bug #30556595  FAILING ASSERTION: !CURSOR->INDEX->IS_COMMITTED()
+--echo # ON TABLE WITH GCOLS
+--echo #
+
+--echo # Testcase-1
+CREATE TABLE t (pid int PRIMARY KEY,
+                uid int,
+                vid int AS (uid) VIRTUAL);
+connect(con1,localhost,root,,);
+--echo # Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+--send ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace
+connection default;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+--echo # Insert a record to generate an insert row log for the new index.
+--echo # LOG-1 idx_vid : INSERT [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+--echo # Update the record changing PK. It should generate 2 row logs for the new index.
+--echo # LOG-2 idx_vid : DELETE [10, 1]
+--echo # LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SELECT * FROM t;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+connection con1;
+--reap
+connection default;
+--echo # Insert a record to re-use the delete marked record in idx_vid [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+SELECT * FROM t;
+disconnect con1;
+DROP TABLE t;
+
+--echo # Testcase-2
+CREATE TABLE t (pid int PRIMARY KEY,
+                uid int,
+                vid int AS (uid) VIRTUAL);
+connect(con1,localhost,root,,);
+--echo # Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+--send ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace
+connection default;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+--echo # Start transaction
+BEGIN;
+--echo # Insert a record to generate an insert row log for the new index.
+--echo # LOG-1 idx_vid : INSERT [10, 1]
+INSERT INTO t(pid, uid) VALUES (1,10);
+--echo # Update the record changing PK. It should generate 2 row logs for the new index.
+--echo # LOG-2 idx_vid : DELETE [10, 1]
+--echo # LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SELECT * FROM t;
+--echo # Rollback transaction
+--echo # LOG-4 idx_vid : DELETE [10, 2]
+--echo # LOG-5 idx_vid : INSERT [10, 1]
+--echo # LOG-6 idx_vid : DELETE [10, 1]
+ROLLBACK;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+connection con1;
+--reap
+connection default;
+--echo # Insert a record to check valid entry in idx_vid [NULL, 1]
+INSERT INTO t(pid) VALUES (1);
+SELECT * FROM t;
+disconnect con1;
+DROP TABLE t;
+
+--echo # Testcase-3
+CREATE TABLE t (pid int PRIMARY KEY,
+                uid int,
+                vid int AS (uid) VIRTUAL);
+INSERT INTO t(pid, uid) VALUES (1,10);
+connect(con1,localhost,root,,);
+--echo # Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+--send ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace
+connection default;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+--echo # Update the record changing PK. It should generate 2 row logs for the new index.
+--echo # LOG-2 idx_vid : DELETE [10, 1]
+--echo # LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+connection con1;
+--reap
+connection default;
+--echo # Read [2, 10, 10] row using idx_vid index key.
+--sleep 1
+select * from t where VID=10;
+disconnect con1;
+DROP TABLE t;
+
+--echo # Testcase-4
+CREATE TABLE t (pid int PRIMARY KEY,
+                uid int,
+                vid int AS (uid) VIRTUAL);
+INSERT INTO t(pid, uid) VALUES (1,10);
+connect(con1,localhost,root,,);
+--echo # Create index on virtual column and stop before applying row logs.
+SET DEBUG_SYNC = 'row_log_apply_before SIGNAL start_dml WAIT_FOR resume_ddl';
+--send ALTER TABLE t ADD INDEX idx_vid(vid), algorithm=inplace
+connection default;
+SET DEBUG_SYNC= 'now WAIT_FOR start_dml';
+--echo # Update the record changing PK. It should generate 2 row logs for the new index.
+--echo # LOG-2 idx_vid : DELETE [10, 1]
+--echo # LOG-3 idx_vid : INSERT [10, 2]
+UPDATE t SET pid = 2 WHERE pid = 1;
+SET DEBUG_SYNC= 'now SIGNAL resume_ddl';
+connection con1;
+--reap
+connection default;
+--echo # Delete a record.
+delete from t limit 1;
+disconnect con1;
+DROP TABLE t;
diff --git a/mysql-test/suite/innodb/t/virtual_index.test b/mysql-test/suite/innodb/t/virtual_index.test
