Bug#22782203 ACCESSING UNINITIALIZED MEMORY INSIDE STRINGS/DECIMAL.C ULL2DEC LINE ~1071

Bug#22839915 UNINTIALIZED VALUE IN DECIMAL_ROUND WITH DECIMAL CONVERSIONS

Problem: misc valgrind warnings in the sanity() macro.
Fix: remove reading of uninitialized buffer contents.

Author: Tor Didriksen

mysql-test/r/type_newdecimal.result

@@ -2175,6 +2175,13 @@ Warnings:
 Warning	1292	Truncated incorrect time value: '-t'
 DROP TABLE t;
 #
+# Bug#22839915 UNINTIALIZED VALUE IN DECIMAL_ROUND
+#               WITH DECIMAL CONVERSIONS
+#
+select maketime(1,1.1,1);
+maketime(1,1.1,1)
+01:01:01
+#
 # Bug#21462523 RETURNED VALUE OVERFLOWS DECIMAL DATA TYPE
 #
 CREATE TABLE t1

mysql-test/t/type_newdecimal.test

@@ -1751,6 +1751,13 @@ INSERT INTO t VALUES(0);
 SELECT 1 FROM t WHERE a<=>time('-t');
 DROP TABLE t;
 
+--echo #
+--echo # Bug#22839915 UNINTIALIZED VALUE IN DECIMAL_ROUND
+--echo #               WITH DECIMAL CONVERSIONS
+--echo #
+
+select maketime(1,1.1,1);
+
 --echo #
 --echo # Bug#21462523 RETURNED VALUE OVERFLOWS DECIMAL DATA TYPE
 --echo #

strings/decimal.c

@@ -1,4 +1,4 @@
-/* Copyright (c) 2004, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2004, 2016, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -136,8 +136,7 @@ static const dec1 frac_max[DIG_PER_DEC1-1]={
   999900000, 999990000, 999999000,
   999999900, 999999990 };
 
-#define sanity(d) DBUG_ASSERT((d)->len >0 && ((d)->buf[0] | \
-                              (d)->buf[(d)->len-1] | 1))
+#define sanity(d) DBUG_ASSERT((d)->len >0)
 
 #define FIX_INTG_FRAC_ERROR(len, intg1, frac1, error)                   \
         do                                                              \