You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This patch does two things:
- Changes the enabled column's data type to ENUM('YES', 'NO')
- Removes the script install_rewriter_with_optional_columns.sql
and instead always creates all columns in the normal script.
Only the plugin, its MTR files and install scripts are touched.
@@ -68,19 +68,19 @@ VALUES ( 'SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ?',
68
68
'SELECT * FROM test.t1 WHERE b = ? OR a = ?' );
69
69
SELECT * FROM query_rewrite.rewrite_rules;
70
70
id pattern pattern_database replacement enabled message normalized_pattern
71
-
2 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? Y NULL NULL
72
-
3 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' Y NULL NULL
73
-
4 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? Y NULL NULL
74
-
5 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a Y NULL NULL
75
-
6 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? Y NULL NULL
71
+
2 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? YES NULL NULL
72
+
3 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' YES NULL NULL
73
+
4 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? YES NULL NULL
74
+
5 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a YES NULL NULL
75
+
6 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? YES NULL NULL
76
76
CALL query_rewrite.flush_rewrite_rules();
77
77
SELECT * FROM query_rewrite.rewrite_rules;
78
78
id pattern pattern_database replacement enabled message normalized_pattern
79
-
2 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? Y NULL select `*` from `test`.`t1` where (((`a` = ?) and ?) or (`b` = ?))
80
-
3 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' Y NULL select `a` from `test`.`t1`
81
-
4 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? Y NULL select `a` from `test`.`t1` where (`b` = ?)
82
-
5 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a Y NULL select `*` from `test`.`t2`
83
-
6 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? Y NULL select `*` from `test`.`t1` where ((`a` = ?) or (`b` = ?))
79
+
2 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? YES NULL select `*` from `test`.`t1` where (((`a` = ?) and ?) or (`b` = ?))
80
+
3 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' YES NULL select `a` from `test`.`t1`
81
+
4 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? YES NULL select `a` from `test`.`t1` where (`b` = ?)
82
+
5 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a YES NULL select `*` from `test`.`t2`
83
+
6 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? YES NULL select `*` from `test`.`t1` where ((`a` = ?) or (`b` = ?))
84
84
# Check a query that doesn't have a rewrite rule doesn't get rewritten.
@@ -280,19 +280,19 @@ VALUES ( 'SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ?',
280
280
'SELECT * FROM test.t1 WHERE b = ? OR a = ?' );
281
281
SELECT * FROM query_rewrite.rewrite_rules;
282
282
id pattern pattern_database replacement enabled message normalized_pattern
283
-
11 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? Y NULL NULL
284
-
12 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' Y NULL NULL
285
-
13 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? Y NULL NULL
286
-
14 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a Y NULL NULL
287
-
15 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? Y NULL NULL
283
+
11 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? YES NULL NULL
284
+
12 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' YES NULL NULL
285
+
13 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? YES NULL NULL
286
+
14 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a YES NULL NULL
287
+
15 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? YES NULL NULL
288
288
CALL query_rewrite.flush_rewrite_rules();
289
289
SELECT * FROM query_rewrite.rewrite_rules;
290
290
id pattern pattern_database replacement enabled message normalized_pattern
291
-
11 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? Y NULL select `*` from `test`.`t1` where (((`a` = ?) and ?) or (`b` = ?))
292
-
12 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' Y NULL select `a` from `test`.`t1`
293
-
13 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? Y NULL select `a` from `test`.`t1` where (`b` = ?)
294
-
14 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a Y NULL select `*` from `test`.`t2`
295
-
15 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? Y NULL select `*` from `test`.`t1` where ((`a` = ?) or (`b` = ?))
291
+
11 SELECT * FROM test.t1 WHERE ( a = ? AND TRUE ) OR b = ? NULL SELECT a FROM test.t1 WHERE a = ? YES NULL select `*` from `test`.`t1` where (((`a` = ?) and ?) or (`b` = ?))
292
+
12 SELECT a FROM test.t1 NULL SELECT * FROM test.t1 WHERE a = 'abc' YES NULL select `a` from `test`.`t1`
293
+
13 SELECT a FROM test.t1 WHERE b = ? NULL SELECT * FROM test.t1 WHERE b = ? YES NULL select `a` from `test`.`t1` where (`b` = ?)
294
+
14 SELECT * FROM test.t2 NULL SELECT * FROM test.t1 JOIN test.t2 ON t1.a = t2.a YES NULL select `*` from `test`.`t2`
295
+
15 SELECT * FROM test.t1 WHERE a = ? OR b = ? NULL SELECT * FROM test.t1 WHERE b = ? OR a = ? YES NULL select `*` from `test`.`t1` where ((`a` = ?) or (`b` = ?))
296
296
# Check a query that doesn't have a rewrite rule doesn't get rewritten.
0 commit comments