Bug#33866103 : MYSQLPUMP [ERROR] (1356) WITH VIEW CONTAINING FROM

               SUBQUERY - REGRESSION

Description:
Mysqlpump may not work in cases where derived tables are generated.
This is due to privileges not being set for those tables.

Fix:
Backport. Derived tables handled separately and privileges set.

Gerrit#16933

Change-Id: Ia31d479ed2d7aba47993d2e646efb84651ee784a

Author: Omar Sharieff

mysql-test/r/mysqlpump_bugs.result

@@ -19,4 +19,13 @@ CREATE VIEW B32067013.t123 AS SELECT * FROM B32067013.t1;
 DROP TABLE B32067013.t1;
 # Test criteria: shouldn't crash
 DROP DATABASE B32067013;
+#
+# Bug#33866103 : MYSQLPUMP [ERROR] (1356) WITH VIEW CONTAINING FROM SUBQUERY - REGRESSION
+#
+CREATE DATABASE db1;
+CREATE TABLE db1.t1 (c1 int);
+CREATE TABLE db1.t2 (c1 int);
+USE db1;
+CREATE VIEW db1.v12 AS (SELECT * FROM (SELECT * FROM db1.t1 UNION SELECT * FROM db1.t2) AS t12);
+DROP DATABASE db1;
 # End of 5.7 tests

mysql-test/t/mysqlpump_bugs.test

@@ -46,4 +46,24 @@ DROP DATABASE B32067013;
 --remove_file $MYSQLTEST_VARDIR/tmp/bug32067013.dump
 
 
+--echo #
+--echo # Bug#33866103 : MYSQLPUMP [ERROR] (1356) WITH VIEW CONTAINING FROM SUBQUERY - REGRESSION
+--echo #
+
+CREATE DATABASE db1;
+
+CREATE TABLE db1.t1 (c1 int);
+CREATE TABLE db1.t2 (c1 int);
+
+USE db1;
+
+CREATE VIEW db1.v12 AS (SELECT * FROM (SELECT * FROM db1.t1 UNION SELECT * FROM db1.t2) AS t12);
+
+--exec $MYSQL_PUMP -u root --result-file=$MYSQLTEST_VARDIR/tmp/bug33866103.sql
+
+--remove_file $MYSQLTEST_VARDIR/tmp/bug33866103.sql
+
+DROP DATABASE db1;
+
+
 --echo # End of 5.7 tests

sql/auth/sql_authorization.cc

@@ -608,6 +608,11 @@ bool check_one_table_access(THD *thd, ulong privilege, TABLE_LIST *all_tables)
 bool check_single_table_access(THD *thd, ulong privilege, 
                                TABLE_LIST *all_tables, bool no_errors)
 {
+  if (all_tables->is_derived()) {
+    all_tables->set_privileges(privilege);
+    return false;
+  }
+
   Security_context *backup_ctx= thd->security_context();
 
   /* we need to switch to the saved context (if any) */