Skip to content

Commit e5115d8

Browse files
author
Tor Didriksen
committed
Bug#22561096 UPGRADE TO CMAKE 3.2.3 BROKE NDBCLUSTER WINDOWS BUILD IN MYSQL-TRUNK
Bug#22572632 CMAKE WARNING IN NDB_CHECK_MYSQL_INCLUDE_FILE.CMAKE Backport to 5.7
1 parent b24fedd commit e5115d8

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

scripts/CMakeLists.txt

+3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ IF(NOT CMAKE_CROSSCOMPILING)
1919
TARGET_LINK_LIBRARIES(comp_sql)
2020
ENDIF()
2121

22+
# Add compiler information, for easier debugging of output from mysql_config.
23+
SET(COMPILER_ID_AND_VERSION
24+
"${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}")
2225

2326
# Build mysql_fix_privilege_tables.sql (concatenate 2 sql scripts)
2427
IF(NOT WIN32 OR CMAKE_CROSSCOMPILING)

storage/ndb/cmake/ndb_check_mysql_include_file.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
1+
# Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
22
#
33
# This program is free software; you can redistribute it and/or modify
44
# it under the terms of the GNU General Public License as published by
@@ -14,7 +14,7 @@
1414
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
1515

1616
MACRO(NDB_CHECK_MYSQL_INCLUDE_FILE INCLUDE VARIABLE)
17-
IF("${VARIABLE}" MATCHES "^${VARIABLE}$")
17+
IF("${${VARIABLE}}" MATCHES "^${${VARIABLE}}$")
1818
SET(_msg "Looking for MySQL include file ${INCLUDE}")
1919
MESSAGE(STATUS "${_msg}")
2020
IF(EXISTS "${CMAKE_SOURCE_DIR}/include/${INCLUDE}")

storage/ndb/cmake/ndb_require_variable.cmake

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2010, 2012, Oracle and/or its affiliates. All rights reserved.
1+
# Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
22
#
33
# This program is free software; you can redistribute it and/or modify
44
# it under the terms of the GNU General Public License as published by
@@ -20,8 +20,8 @@
2020
#
2121
MACRO(NDB_REQUIRE_VARIABLE variable_name)
2222
#MESSAGE(STATUS "Checking variable ${variable_name} required by NDB")
23-
IF(NOT "${variable_name}")
23+
IF("${${variable_name}}" STREQUAL "")
2424
MESSAGE(FATAL_ERROR "The variable ${variable_name} is required "
2525
"to build NDB")
2626
ENDIF()
27-
ENDMACRO()
27+
ENDMACRO()

0 commit comments

Comments
 (0)