Bug#18675099: WINDOWSCACHE.CMAKE MUST BE UPDATED FOR VS2013

WindowsCache.cmake hardcodes results for CMake configure checks so they
don't have to be performed on Windows (as this is very slow).

The problem was that the cache file had several values which were no
longer correct. The consequence that we were using Windows specific
workarounds in cases where it was no longer needed.

This patch removes the outdated values from the cache file so that the
checks are actually made. It also reorganizes the cache file so that it
matches config.h.cmake, removes duplicate entries, removes dead
entries and adds missing entries. The patch also removes some
unneeded Visual Studio version checks.

Author: jhauglid

cmake/os/Windows.cmake

@@ -60,15 +60,7 @@ ADD_DEFINITIONS("-DWIN32_LEAN_AND_MEAN")
 ADD_DEFINITIONS("-DNOMINMAX")
 
 # Should be available on Windows Server 2003 and above.
-CHECK_CXX_SOURCE_COMPILES(
-"#include <Windows.h>
-int main() {
-  GetCurrentProcessorNumber();
-  return 0;
-} " HAVE_GETCURRENTPROCESSORNUMBER)
-IF(HAVE_GETCURRENTPROCESSORNUMBER)
- ADD_DEFINITIONS(-DHAVE_GETCURRENTPROCESSORNUMBER=1)
-ENDIF()
+ADD_DEFINITIONS(-DHAVE_GETCURRENTPROCESSORNUMBER=1)
 
 IF(MSVC)
   # Enable debug info also in Release build,
@@ -118,10 +110,8 @@ IF(MSVC)
   ENDIF()
 
   # Speed up multiprocessor build
-  IF (MSVC_VERSION GREATER 1400)
-    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /MP")
-    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP")
-  ENDIF()
+  SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /MP")
+  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP")
 
   #TODO: update the code and remove the disabled warnings
   SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4800 /wd4805 /wd4996")