Bug#19418619 - SELECT QUERY WITH INVALID TIME WORKS FINE

               BUT SP FAILS UNDER STRICT MODE

Description:

STRICT sql mode does not apply to SELECT statement except
for invalid arguments to sleep(). SELECT statement gives
warning for invalid data in STRICT mode, which is correct
behavior. If same SELECT statement is executed from within
Stored Procedure, it gives error and abort statement.
Statement behavior should not change if executed from Stored
Procedure. Same case exist for SET statement.

Another issue, CREATE TABLE statement fails while CREATE
INDEX statement passes for too long indexes in STRICT mode.
Index creation should behave same if executed from
CREATE TABLE or CREATE INDEX statement.

Analysis:

This is a regression from WL#6891. Stored Procedures are
executed in the sql mode they were created. When SP was
created in STRICT mode, Strict_error_handler was pushed
before executing statements inside the Stored Procedure.
This upgrades warnings to error for every SELECT statement.
Other side effects of above change are:
- Changing STRICT sql mode inside Stored Procedure would
  have no effect.
- As documented, evaluation of SP and SF parameters should
  depend on the current sql mode instead of the mode in
  which SP/SF was created. Behavior got changed with WL#6891
  and parameter evaluation started using sql_mode in which
  SP/SF were created.

Strict_error_handler was missing check for CREATE INDEX
statement. So, where CREATE TABLE will give error for too long
indexes, CREATE INDEX statement will succeed with warning in
STRICT mode.

Fix:

Fixed code to push Strict_error_handler when required.
SELECT inside and outside Stored Procedure will behave
same. Exception for this is when we do SELECT on variables
declared inside Stored Procedure.
Consider the procedure :

create procedure proc1()
begin
  declare div_zero integer;
  select 1/0 into div_zero;
end

Here, SELECT to assign invalid value to 'div_zero' will
fail in STRICT mode as it follows the rules of assigning a
value to INTEGER column in a table. There is no behavior
change here.
Same case applies to SET statement.

Now STRICT mode setting can be changed inside Stored
Procedures and parameter evaluation will depend on current
sql mode.

Added check for CREATE INDEX statement in Strict_error_handler.

Author: abhi5466

mysql-test/r/archive.result

@@ -12878,6 +12878,7 @@ DROP TABLE t1;
 DROP TABLE IF EXISTS t1;
 CREATE TABLE t1 (c1 decimal(19,14) NOT NULL) ENGINE=ARCHIVE;
 CALL mtr.add_suppression("Found wrong key definition in #sql.* Please do \"ALTER TABLE `#sql.*` FORCE \" to fix it!");
+SET sql_mode='NO_ENGINE_SUBSTITUTION';
 CREATE INDEX i1 ON t1(c1);
 ERROR HY000: Got error -1 from storage engine
 SHOW WARNINGS;
@@ -12886,6 +12887,7 @@ Warning	1071	Specified key was too long; max key length is 8 bytes
 Warning	1194	Found wrong key definition in #sql-temporary; Please do "ALTER TABLE `#sql-temporary` FORCE" to fix it!
 Warning	1194	Found wrong key definition in #sql-temporary; Please do "ALTER TABLE `#sql-temporary` FORCE" to fix it!
 Error	1030	Got error -1 from storage engine
+SET sql_mode= default;
 DROP TABLE t1;
 #
 # BUG#11758979 - 51252: ARCHIVE TABLES STILL FAIL UNDER STRESS

mysql-test/r/partition.result

@@ -2635,7 +2635,7 @@ CREATE TABLE t1 (d TIME)
 PARTITION BY RANGE COLUMNS (d)
 (PARTITION p0 VALUES LESS THAN ('2000-01-01'),
 PARTITION p1 VALUES LESS THAN ('2040-01-01'));
-ERROR 22007: Incorrect time value: '2000-01-01' for column 'd' at row 1
+ERROR HY000: Partition column values of incorrect type
 SELECT @@sql_mode;
 @@sql_mode
 STRICT_TRANS_TABLES

mysql-test/r/sp-bugs.result

@@ -228,3 +228,139 @@ testf_bug11763507
 DROP PROCEDURE testp_bug11763507;
 DROP FUNCTION testf_bug11763507;
 #END OF BUG#11763507 test.
+#
+# Bug#19418619 : SELECT QUERY WITH INVALID TIME WORKS FINE BUT SP FAILS UNDER STRICT MODE
+#
+SET sql_mode='NO_ENGINE_SUBSTITUTION';
+CREATE FUNCTION f1(arg TINYINT UNSIGNED) RETURNS TINYINT
+BEGIN
+RETURN abs('1abcd');
+END|
+SELECT f1(-25);
+f1(-25)
+1
+Warnings:
+Warning	1264	Out of range value for column 'arg' at row 1
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+SELECT f1(25);
+f1(25)
+1
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+SET sql_mode='STRICT_ALL_TABLES,STRICT_TRANS_TABLES';
+SELECT f1(-25);
+ERROR 22003: Out of range value for column 'arg' at row 1
+SELECT f1(10);
+f1(10)
+1
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+DROP FUNCTION f1;
+SET sql_mode='NO_ENGINE_SUBSTITUTION';
+CREATE PROCEDURE f1(IN arg TINYINT UNSIGNED)
+BEGIN
+DECLARE arg1 TINYINT;
+select abs('1abcd') into arg;
+END|
+CALL f1(-25);
+Warnings:
+Warning	1264	Out of range value for column 'arg' at row 1
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+CALL f1(25);
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+SET sql_mode='STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION';
+CALL f1(-25);
+ERROR 22003: Out of range value for column 'arg' at row 1
+CALL f1(10);
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: '1abcd'
+DROP PROCEDURE f1;
+SELECT SUBTIME('2006-07-16' , '05:05:02.040778');
+SUBTIME('2006-07-16' , '05:05:02.040778')
+-04:44:56.040778
+Warnings:
+Warning	1292	Truncated incorrect time value: '2006-07-16'
+SELECT abs('1bcd');
+abs('1bcd')
+1
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: '1bcd'
+CREATE PROCEDURE sp1()
+BEGIN
+SELECT SUBTIME('2006-07-16' , '05:05:02.040778');
+END|
+CREATE PROCEDURE sp2()
+BEGIN
+DECLARE v1 TINYINT DEFAULT 450000;
+END|
+CALL sp1();
+SUBTIME('2006-07-16' , '05:05:02.040778')
+-04:44:56.040778
+Warnings:
+Warning	1292	Truncated incorrect time value: '2006-07-16'
+CALL sp2();
+ERROR 22003: Out of range value for column 'v1' at row 1
+DROP PROCEDURE sp1;
+DROP PROCEDURE sp2;
+CREATE FUNCTION fn1(arg TINYINT UNSIGNED) RETURNS float deterministic RETURN abs('1abcd');
+CREATE FUNCTION fn2() RETURNS tinyint
+BEGIN
+DECLARE v1 TINYINT DEFAULT 450000;
+RETURN v1;
+END|
+SELECT fn1(25);
+ERROR 22007: Truncated incorrect DOUBLE value: '1abcd'
+SELECT fn1(-25);
+ERROR 22003: Out of range value for column 'arg' at row 1
+SELECT fn2();
+ERROR 22003: Out of range value for column 'v1' at row 1
+SET sql_mode='NO_ENGINE_SUBSTITUTION';
+SELECT fn1(-25);
+ERROR 22007: Truncated incorrect DOUBLE value: '1abcd'
+DROP FUNCTION fn1;
+DROP FUNCTION fn2;
+CREATE FUNCTION fn1() RETURNS float deterministic RETURN floor('1.1a');
+SET sql_mode='STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION';
+CREATE TABLE t1(a INT);
+CREATE FUNCTION fn2() RETURNS float deterministic RETURN floor('1.1a');
+CREATE TRIGGER tr1 BEFORE INSERT ON t1 FOR EACH ROW SET @a=fn2();
+INSERT INTO t1 VALUES(1);
+ERROR 22007: Truncated incorrect DOUBLE value: '1.1a'
+DROP TRIGGER tr1;
+CREATE TRIGGER tr1 BEFORE INSERT ON t1 FOR EACH ROW SET @a=fn1();
+INSERT INTO t1 VALUES(1);
+DROP FUNCTION fn1;
+DROP FUNCTION fn2;
+DROP TRIGGER tr1;
+DROP TABLE t1;
+SET sql_mode=traditional;
+SELECT 1/0;
+1/0
+NULL
+Warnings:
+Warning	1365	Division by 0
+SET sql_mode='';
+CREATE PROCEDURE proc_c()
+BEGIN
+DECLARE div_zero INTEGER;
+SET SQL_MODE='TRADITIONAL';
+SELECT 1/0;
+END|
+CALL proc_c();
+1/0
+NULL
+Warnings:
+Warning	1365	Division by 0
+DROP PROCEDURE proc_c;
+SET sql_mode=traditional;
+CREATE FUNCTION fn1() RETURNS TINYINT
+BEGIN
+SET  @x=floor('1a');
+RETURN 1;
+END|
+SELECT fn1();
+fn1()
+1
+DROP FUNCTION fn1;
+SET sql_mode= default;

mysql-test/r/sp-vars.result

@@ -848,10 +848,7 @@ Warnings:
 Warning	1264	Out of range value for column 'arg' at row 1
 SET @@sql_mode = 'traditional';
 SELECT f1(-2500);
-f1(-2500)
-0
-Warnings:
-Warning	1264	Out of range value for column 'arg' at row 1
+ERROR 22003: Out of range value for column 'arg' at row 1
 DROP FUNCTION f1;
 CREATE FUNCTION f1(arg TINYINT UNSIGNED) RETURNS TINYINT
 BEGIN
@@ -878,10 +875,7 @@ Warnings:
 Warning	1264	Out of range value for column 'arg' at row 1
 SET @@sql_mode = 'traditional';
 SELECT f1(8388699);
-f1(8388699)
-8388607
-Warnings:
-Warning	1264	Out of range value for column 'arg' at row 1
+ERROR 22003: Out of range value for column 'arg' at row 1
 DROP FUNCTION f1;
 CREATE FUNCTION f1(arg MEDIUMINT) RETURNS MEDIUMINT
 BEGIN

mysql-test/r/sp.result

@@ -5407,17 +5407,15 @@ select func_20028_b()|
 func_20028_b()
 0
 select func_20028_c()|
-func_20028_c()
-NULL
+ERROR 22012: Division by 0
 call proc_20028_a()|
 Warnings:
 Warning	1329	No data - zero rows fetched, selected, or processed
 call proc_20028_b()|
 Warnings:
 Warning	1329	No data - zero rows fetched, selected, or processed
 call proc_20028_c()|
-Warnings:
-Warning	1365	Division by 0
+ERROR 22012: Division by 0
 SET sql_mode='TRADITIONAL'|
 drop function func_20028_a|
 drop function func_20028_b|

mysql-test/r/trigger.result

@@ -1059,10 +1059,9 @@ SELECT @x;
 NULL
 SET @x=2;
 UPDATE t1 SET i1 = @x;
-ERROR 22012: Division by 0
 SELECT @x;
 @x
-2
+NULL
 SET SQL_MODE='';
 SET @x=3;
 INSERT INTO t1 VALUES (@x);
@@ -1071,10 +1070,9 @@ SELECT @x;
 NULL
 SET @x=4;
 UPDATE t1 SET i1 = @x;
-ERROR 22012: Division by 0
 SELECT @x;
 @x
-4
+NULL
 SET @@sql_mode=@save_sql_mode;
 DROP TRIGGER t1_ai;
 DROP TRIGGER t1_au;
@@ -1182,7 +1180,6 @@ Warnings:
 Warning	1365	Division by 0
 create trigger t1_bi before insert on t1 for each row set @a:=1/0|
 insert into t1 values(20, 20)|
-ERROR 22012: Division by 0
 drop trigger t1_bi|
 create trigger t1_bi before insert on t1 for each row
 begin
@@ -1201,10 +1198,9 @@ set @a:=1/0;
 end|
 set @check=0, @t4_bi_called=0, @t4_bu_called=0|
 insert into t1 values(30, 30)|
-ERROR 22012: Division by 0
 select @check, @t4_bi_called, @t4_bu_called|
 @check	@t4_bi_called	@t4_bu_called
-1	1	1
+2	1	1
 SET @@sql_mode=@save_sql_mode;
 drop table t1;
 drop table t2;

mysql-test/suite/innodb_zip/r/index_large_prefix.result

@@ -93,18 +93,16 @@ create table worklog5743_8(a1 int, a2 TEXT, a3 TEXT) KEY_BLOCK_SIZE=8;
 create table worklog5743_16(a1 int, a2 TEXT, a3 TEXT) KEY_BLOCK_SIZE=16;
 set global innodb_large_prefix=0;
 create index idx1 on worklog5743_1(a2(4000));
-ERROR 42000: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs
+ERROR 42000: Specified key was too long; max key length is 767 bytes
 show warnings;
 Level	Code	Message
-Warning	1071	Specified key was too long; max key length is 767 bytes
-Error	1118	Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs
+Error	1071	Specified key was too long; max key length is 767 bytes
 set global innodb_large_prefix=1;
-SET sql_mode = 'NO_ENGINE_SUBSTITUTION';
 create index idx2 on worklog5743_1(a2(4000));
-ERROR 42000: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs
-SET sql_mode = default;
+ERROR 42000: Specified key was too long; max key length is 3072 bytes
 show warnings;
 Level	Code	Message
+Error	1071	Specified key was too long; max key length is 3072 bytes
 create index idx3 on worklog5743_1(a2(436));
 ERROR 42000: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs
 show warnings;
@@ -122,6 +120,7 @@ create index idx6 on worklog5743_1(a1, a2(428));
 show warnings;
 Level	Code	Message
 set global innodb_large_prefix=0;
+SET sql_mode= '';
 create index idx1 on worklog5743_2(a2(4000));
 Warnings:
 Warning	1071	Specified key was too long; max key length is 767 bytes
@@ -253,6 +252,7 @@ Error	1071	Specified key was too long; max key length is 3072 bytes
 create index idx7 on worklog5743_16(a1, a2(2000), a3(1068));
 show warnings;
 Level	Code	Message
+set sql_mode= default;
 insert into worklog5743_1 values(9, repeat("a", 10000));
 insert into worklog5743_2 values(9, repeat("a", 10000));
 insert into worklog5743_4 values(9, repeat("a", 10000));
@@ -382,6 +382,7 @@ a4 varchar(3072),
 a5 varchar(3069),
 a6 varchar(3068))
 ROW_FORMAT=DYNAMIC;
+SET sql_mode='';
 create index idx1 on worklog5743(a2);
 Warnings:
 Warning	1071	Specified key was too long; max key length is 3072 bytes
@@ -391,11 +392,11 @@ Warning	1071	Specified key was too long; max key length is 3072 bytes
 create index idx3 on worklog5743(a4);
 show warnings;
 Level	Code	Message
+SET sql_mode= default;
 create index idx4 on worklog5743(a1, a2);
 ERROR 42000: Specified key was too long; max key length is 3072 bytes
 show warnings;
 Level	Code	Message
-Warning	1071	Specified key was too long; max key length is 3072 bytes
 Error	1071	Specified key was too long; max key length is 3072 bytes
 create index idx5 on worklog5743(a1, a5);
 ERROR 42000: Specified key was too long; max key length is 3072 bytes
@@ -473,6 +474,7 @@ rollback;
 drop table worklog5743;
 ### Test 7 ###
 create table worklog5743(a TEXT not null) ROW_FORMAT=DYNAMIC;
+SET sql_mode='';
 create index idx1 on worklog5743(a(3073));
 Warnings:
 Warning	1071	Specified key was too long; max key length is 3072 bytes
@@ -487,6 +489,7 @@ worklog5743	CREATE TABLE `worklog5743` (
   KEY `idx2` (`a`(3072))
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC
 drop table worklog5743;
+SET sql_mode= default;
 create table worklog5743(a TEXT not null) ROW_FORMAT=REDUNDANT;
 create index idx on worklog5743(a(768));
 ERROR HY000: Index column size too large. The maximum column size is 767 bytes.

mysql-test/suite/innodb_zip/r/prefix_index_liftedlimit.result

@@ -1257,8 +1257,8 @@ WHERE col_1_text = REPEAT("c", 4000) AND col_2_text = REPEAT("o", 4000);
 col_1_text = REPEAT("c", 4000)
 DROP INDEX prefix_idx ON worklog5743;
 CREATE INDEX prefix_idx ON worklog5743(col_1_text (4000));
-Warnings:
-Warning	1071	Specified key was too long; max key length is 3072 bytes
+ERROR 42000: Specified key was too long; max key length is 3072 bytes
+CREATE INDEX prefix_idx ON worklog5743(col_1_text (3072));
 INSERT INTO worklog5743 VALUES(REPEAT("a", 4000),REPEAT("o", 4000));
 SELECT col_1_text = REPEAT("a", 4000) FROM worklog5743;
 col_1_text = REPEAT("a", 4000)
@@ -1373,10 +1373,10 @@ PRIMARY KEY (col_1_varchar(767))
 ) engine = innodb;
 INSERT INTO worklog5743 VALUES(REPEAT('a',4000),REPEAT('b',4000));
 CREATE INDEX prefix_idx ON worklog5743(col_1_varchar (1000));
+ERROR 42000: Specified key was too long; max key length is 767 bytes
+CREATE INDEX prefix_idx ON worklog5743(col_1_varchar (767));
 affected rows: 0
-info: Records: 0  Duplicates: 0  Warnings: 1
-Warnings:
-Warning	1071	Specified key was too long; max key length is 767 bytes
+info: Records: 0  Duplicates: 0  Warnings: 0
 ALTER TABLE worklog5743 ROW_FORMAT=REDUNDANT;
 affected rows: 0
 info: Records: 0  Duplicates: 0  Warnings: 0