Bug #22505474 MYSQLPUMP FAILS WHEN IS DUMPING ALL DATABASES

Problem: When views are named with a space character there
         is a syntax error when dumping view.
Fix: Fixed by quoting the view names.

Author: Bharathy Satish

client/dump/mysql_crawler.cc

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+  Copyright (c) 2015, 2016 Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -238,8 +238,9 @@ void Mysql_crawler::enumerate_views(const Database& db)
       if (is_view[0] == "1")
       {
         /* Check if view dependent objects exists */
-        if (runner->run_query(std::string("LOCK TABLES ") + db.get_name()
-                    + "." + table_name + " READ") != 0)
+        if (runner->run_query(std::string("LOCK TABLES ")
+              + this->get_quoted_object_full_name(db.get_name(), table_name)
+              + " READ") != 0)
           return;
         else
           runner->run_query(std::string("UNLOCK TABLES"));

mysql-test/r/mysqlpump_basic.result

@@ -551,3 +551,26 @@ sum	pk	a	c
 2014	2003-01-02 10:30:00	11	12
 2036	2015-11-22 00:30:00	21	22
 DROP DATABASE bug21650559;
+CREATE DATABASE bug22505474;
+USE bug22505474;
+CREATE TABLE t1 (a INT);
+INSERT INTO t1 VALUES (1),(2),(3);
+CREATE VIEW `v 1` AS SELECT * FROM t1;
+SELECT * FROM `v 1`;
+a
+1
+2
+3
+DROP DATABASE bug22505474;
+USE bug22505474;
+SELECT * FROM t1;
+a
+1
+2
+3
+SELECT * FROM `v 1`;
+a
+1
+2
+3
+DROP DATABASE bug22505474;

mysql-test/t/mysqlpump_basic.test

@@ -477,3 +477,22 @@ SELECT * FROM t1;
 SELECT * FROM t2;
 SELECT * FROM t3;
 DROP DATABASE bug21650559;
+
+#echo
+#echo Bug #22505474 MYSQLPUMP FAILS WHEN IS DUMPING ALL DATABASES
+#echo
+
+CREATE DATABASE bug22505474;
+USE bug22505474;
+CREATE TABLE t1 (a INT);
+INSERT INTO t1 VALUES (1),(2),(3);
+CREATE VIEW `v 1` AS SELECT * FROM t1;
+SELECT * FROM `v 1`;
+--exec $MYSQL_PUMP --databases bug22505474 > $MYSQLTEST_VARDIR/tmp/bug22505474.sql
+DROP DATABASE bug22505474;
+--exec $MYSQL < $MYSQLTEST_VARDIR/tmp/bug22505474.sql
+--remove_file $MYSQLTEST_VARDIR/tmp/bug22505474.sql
+USE bug22505474;
+SELECT * FROM t1;
+SELECT * FROM `v 1`;
+DROP DATABASE bug22505474;