Bug#22710312 VALGRIND: CONDITIONAL JUMP OR MOVE IN REWRITER::DO_REFRESH

Problem: valgrind warnings when loading the rewrite plugin,
and there is no query_rewrite database.

Fix: init m_table_is_malformed to true, in case of early return from Cursor CTOR

Author: Tor Didriksen

mysql-test/suite/query_rewrite_plugins/r/error-nodb.result

@@ -0,0 +1,13 @@
+#
+# Loads the plugin when there is no query_rewrite database
+#
+SET sql_mode = 'PIPES_AS_CONCAT';
+Warnings:
+Warning	3090	Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release.
+CALL mtr.add_suppression("Plugin rewriter reported: " ||
+"'Wrong column count or names when loading rules.'");
+INSTALL PLUGIN rewriter SONAME 'rewriter.xxx';
+UNINSTALL PLUGIN rewriter;
+Warnings:
+Warning	1620	Plugin is busy and will be uninstalled on shutdown
+SET sql_mode = DEFAULT;

mysql-test/suite/query_rewrite_plugins/t/error-nodb-master.opt

@@ -0,0 +1,2 @@
+--no-console
+--log-error=$MYSQL_TMP_DIR/errors.err

mysql-test/suite/query_rewrite_plugins/t/error-nodb.test

@@ -0,0 +1,14 @@
+--echo #
+--echo # Loads the plugin when there is no query_rewrite database
+--echo #
+
+--source suite/query_rewrite_plugins/include/have_plugin_rewriter.inc
+
+SET sql_mode = 'PIPES_AS_CONCAT';
+CALL mtr.add_suppression("Plugin rewriter reported: " ||
+                         "'Wrong column count or names when loading rules.'");
+
+--replace_regex /\.so|\.dll/.xxx/
+eval INSTALL PLUGIN rewriter SONAME '$REWRITER';
+UNINSTALL PLUGIN rewriter;
+SET sql_mode = DEFAULT;

sql/rules_table_service.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -62,7 +62,8 @@ static void add_column(MY_BITMAP *map, Cursor::column_id column)
 Cursor::Cursor(MYSQL_THD mysql_thd) :
   m_thd(mysql_thd),
   m_table_list(NULL),
-  m_is_finished(true)
+  m_is_finished(true),
+  m_table_is_malformed(true)
 {
   m_table_list= new TABLE_LIST;
   if (m_table_list == NULL)