Skip to content

Commit b32d64b

Browse files
committed
mtr: cleaned up some superfluos global warning suppressions
2 parents 82474d2 + fa2385a commit b32d64b

13 files changed

+22
-47
lines changed

mysql-test/extra/rpl_tests/rpl_extra_col_master.test

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,9 @@ SELECT f1,f2,f3,f4,f5,f6,f7,f8,f9,
123123
#connection slave;
124124

125125
call mtr.add_suppression("Slave SQL.*Table definition on master and slave does not match: Column 2 type mismatch.* 1535");
126-
call mtr.add_suppression("Slave SQL.*Error .Can.t DROP .c7.; check that column.key exists. on query.* 1091");
127-
call mtr.add_suppression("Slave SQL.*Error .Unknown column .c7. in .t15.. on query.* 1054");
128-
call mtr.add_suppression("Slave SQL.*Error .Key column .c6. doesn.t exist in table. on query.* 1072");
126+
call mtr.add_suppression("Slave.*Can.t DROP .c7.; check that column.key exists.* Error_code: 1091");
127+
call mtr.add_suppression("Slave.*Unknown column .c7. in .t15.* Error_code: 1054");
128+
call mtr.add_suppression("Slave.*Key column .c6. doesn.t exist in table.* Error_code: 1072");
129129
call mtr.add_suppression("Slave SQL.*Column 2 of table .test.t1.. cannot be converted from type.* Error_code: 1677");
130130

131131
sync_slave_with_master;

mysql-test/include/mix1.inc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -634,6 +634,10 @@ drop table t1;
634634
drop table bug29807;
635635
create table bug29807 (a int);
636636
drop table bug29807;
637+
--disable_query_log
638+
call mtr.add_suppression("InnoDB: Error: table .test...bug29807. does not exist in the InnoDB internal");
639+
call mtr.add_suppression("Cannot find or open table test\/bug29807 from");
640+
--enable_query_log
637641

638642

639643
#

mysql-test/include/mtr_warnings.sql

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ SET @@collation_connection = @collation_connection_saved||
7171
-- Insert patterns that should always be suppressed
7272
--
7373
INSERT INTO global_suppressions VALUES
74-
("'SELECT UNIX_TIMESTAMP\\(\\)' failed on master"),
74+
(".SELECT UNIX_TIMESTAMP... failed on master"),
7575
("Aborted connection"),
7676
("Client requested master to start replication from impossible position"),
7777
("Could not find first log file name in binary log"),
@@ -128,7 +128,6 @@ INSERT INTO global_suppressions VALUES
128128
("Sort aborted"),
129129
("Time-out in NDB"),
130130
("Warning:\s+One can only use the --user.*root"),
131-
("Warning:\s+Setting lower_case_table_names=2"),
132131
("Warning:\s+Table:.* on (delete|rename)"),
133132
("You have an error in your SQL syntax"),
134133
("deprecated"),
@@ -141,59 +140,25 @@ INSERT INTO global_suppressions VALUES
141140
("slave SQL thread aborted"),
142141
("Slave: .*Duplicate entry"),
143142

144-
/*
145-
Special case, made as specific as possible, for:
146-
Bug #28436: Incorrect position in SHOW BINLOG EVENTS causes
147-
server coredump
148-
*/
149-
150-
("Error in Log_event::read_log_event\\\(\\\): 'Sanity check failed', data_len: 258, event_type: 49"),
151-
152143
("Statement may not be safe to log in statement format"),
153144

154-
/* test case for Bug#bug29807 copies a stray frm into database */
155-
("InnoDB: Error: table `test`.`bug29807` does not exist in the InnoDB internal"),
156-
("Cannot find or open table test\/bug29807 from"),
157-
158145
/* innodb foreign key tests that fail in ALTER or RENAME produce this */
159146
("InnoDB: Error: in ALTER TABLE `test`.`t[123]`"),
160147
("InnoDB: Error: in RENAME TABLE table `test`.`t1`"),
161148
("InnoDB: Error: table `test`.`t[123]` does not exist in the InnoDB internal"),
162149

163-
/* Test case for Bug#14233 produces the following warnings: */
164-
("Stored routine 'test'.'bug14233_1': invalid value in column mysql.proc"),
165-
("Stored routine 'test'.'bug14233_2': invalid value in column mysql.proc"),
166-
("Stored routine 'test'.'bug14233_3': invalid value in column mysql.proc"),
167-
168150
/*
169151
BUG#32080 - Excessive warnings on Solaris: setrlimit could not
170152
change the size of core files
171153
*/
172154
("setrlimit could not change the size of core files to 'infinity'"),
173155

174-
/*
175-
rpl_extrColmaster_*.test, the slave thread produces warnings
176-
when it get updates to a table that has more columns on the
177-
master
178-
*/
179-
("Slave: Unknown column 'c7' in 't15' Error_code: 1054"),
180-
("Slave: Can't DROP 'c7'.* 1091"),
181-
("Slave: Key column 'c6'.* 1072"),
182156
("The slave I.O thread stops because a fatal error is encountered when it tries to get the value of SERVER_UUID variable from master.*"),
183157
("The initialization command '.*' failed with the following error.*"),
184-
("The slave I.O thread stops because a fatal error is encountered when it try to get the value of SERVER_ID variable from master."),
185-
(".SELECT UNIX_TIMESTAMP... failed on master, do not trust column Seconds_Behind_Master of SHOW SLAVE STATUS"),
186158

187159
/*It will print a warning if a new UUID of server is generated.*/
188160
("No existing UUID has been found, so we assume that this is the first time that this server has been started.*"),
189161

190-
/* Special case for Bug #26402 in show_check.test
191-
- Question marks are not valid file name parts on Windows. Ignore
192-
this error message.
193-
*/
194-
("Can't find file: '.\\\\test\\\\\\?{8}.frm'"),
195-
("Slave: Unknown table 'test.t1' Error_code: 1051"),
196-
197162
/* Added 2009-08-XX after fixing Bug #42408 */
198163

199164
("Although a path was specified for the .* option, log tables are used"),

mysql-test/include/order_by.inc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -847,8 +847,7 @@ CALL mtr.add_suppression("Out of sort memory");
847847
--error ER_OUT_OF_SORTMEMORY
848848
select * from t1 order by b;
849849
drop table t1;
850-
851-
850+
call mtr.add_suppression("Out of sort memory; increase server sort buffer size");
852851
--echo #
853852
--echo # Bug #39844: Query Crash Mysql Server 5.0.67
854853
--echo #

mysql-test/r/order_by_all.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1430,6 +1430,7 @@ CALL mtr.add_suppression("Out of sort memory");
14301430
select * from t1 order by b;
14311431
ERROR HY001: Out of sort memory, consider increasing server sort buffer size
14321432
drop table t1;
1433+
call mtr.add_suppression("Out of sort memory; increase server sort buffer size");
14331434
#
14341435
# Bug #39844: Query Crash Mysql Server 5.0.67
14351436
#

mysql-test/r/order_by_icp_mrr.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1430,6 +1430,7 @@ CALL mtr.add_suppression("Out of sort memory");
14301430
select * from t1 order by b;
14311431
ERROR HY001: Out of sort memory, consider increasing server sort buffer size
14321432
drop table t1;
1433+
call mtr.add_suppression("Out of sort memory; increase server sort buffer size");
14331434
#
14341435
# Bug #39844: Query Crash Mysql Server 5.0.67
14351436
#

mysql-test/r/order_by_none.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,6 +1429,7 @@ CALL mtr.add_suppression("Out of sort memory");
14291429
select * from t1 order by b;
14301430
ERROR HY001: Out of sort memory, consider increasing server sort buffer size
14311431
drop table t1;
1432+
call mtr.add_suppression("Out of sort memory; increase server sort buffer size");
14321433
#
14331434
# Bug #39844: Query Crash Mysql Server 5.0.67
14341435
#

mysql-test/r/show_check.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1338,6 +1338,7 @@ Name Engine Version Row_format Rows Avg_row_length Data_length Max_data_length I
13381338
DROP DATABASE `�`;
13391339
show columns from `#mysql50#????????`;
13401340
Got one of the listed errors
1341+
call mtr.add_suppression("Can.t find file: '.\\\\test\\\\\\?{8}.frm'");
13411342
DROP TABLE IF EXISTS t1;
13421343
DROP PROCEDURE IF EXISTS p1;
13431344
CREATE TABLE t1(c1 INT);

mysql-test/r/sp-destruct.result

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
call mtr.add_suppression("Column count of mysql.proc is wrong. Expected 20, found 19. The table is probably corrupted");
2+
call mtr.add_suppression("Stored routine .test...bug14233_[123].: invalid value in column mysql.proc");
23
use test;
34
drop procedure if exists bug14233;
45
drop function if exists bug14233;

mysql-test/suite/rpl/r/rpl_extra_col_master_innodb.result

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ f1 f2 f3 f4 f5 f6 f7 f8 f9 hex(f10) hex(f11)
5858
29 29 29 second 2 kaks 2 got stolen from the paradise very fat blob 1555 123456
5959
30 30 30 next 2 kaks 2 got stolen from the paradise very fat blob 1555 123456
6060
call mtr.add_suppression("Slave SQL.*Table definition on master and slave does not match: Column 2 type mismatch.* 1535");
61-
call mtr.add_suppression("Slave SQL.*Error .Can.t DROP .c7.; check that column.key exists. on query.* 1091");
62-
call mtr.add_suppression("Slave SQL.*Error .Unknown column .c7. in .t15.. on query.* 1054");
63-
call mtr.add_suppression("Slave SQL.*Error .Key column .c6. doesn.t exist in table. on query.* 1072");
61+
call mtr.add_suppression("Slave.*Can.t DROP .c7.; check that column.key exists.* Error_code: 1091");
62+
call mtr.add_suppression("Slave.*Unknown column .c7. in .t15.* Error_code: 1054");
63+
call mtr.add_suppression("Slave.*Key column .c6. doesn.t exist in table.* Error_code: 1072");
6464
call mtr.add_suppression("Slave SQL.*Column 2 of table .test.t1.. cannot be converted from type.* Error_code: 1677");
6565

6666
* Select count and 20 rows from Slave *

mysql-test/suite/rpl/r/rpl_extra_col_master_myisam.result

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ f1 f2 f3 f4 f5 f6 f7 f8 f9 hex(f10) hex(f11)
5858
29 29 29 second 2 kaks 2 got stolen from the paradise very fat blob 1555 123456
5959
30 30 30 next 2 kaks 2 got stolen from the paradise very fat blob 1555 123456
6060
call mtr.add_suppression("Slave SQL.*Table definition on master and slave does not match: Column 2 type mismatch.* 1535");
61-
call mtr.add_suppression("Slave SQL.*Error .Can.t DROP .c7.; check that column.key exists. on query.* 1091");
62-
call mtr.add_suppression("Slave SQL.*Error .Unknown column .c7. in .t15.. on query.* 1054");
63-
call mtr.add_suppression("Slave SQL.*Error .Key column .c6. doesn.t exist in table. on query.* 1072");
61+
call mtr.add_suppression("Slave.*Can.t DROP .c7.; check that column.key exists.* Error_code: 1091");
62+
call mtr.add_suppression("Slave.*Unknown column .c7. in .t15.* Error_code: 1054");
63+
call mtr.add_suppression("Slave.*Key column .c6. doesn.t exist in table.* Error_code: 1072");
6464
call mtr.add_suppression("Slave SQL.*Column 2 of table .test.t1.. cannot be converted from type.* Error_code: 1677");
6565

6666
* Select count and 20 rows from Slave *

mysql-test/t/show_check.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,6 +1082,7 @@ DROP DATABASE `
10821082
#
10831083
--error ER_NO_SUCH_TABLE,ER_FILE_NOT_FOUND
10841084
show columns from `#mysql50#????????`;
1085+
call mtr.add_suppression("Can.t find file: '.\\\\test\\\\\\?{8}.frm'");
10851086

10861087
#
10871088
# SHOW CREATE TRIGGER test.

mysql-test/t/sp-destruct.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
# Supress warnings written to the log file
1616
call mtr.add_suppression("Column count of mysql.proc is wrong. Expected 20, found 19. The table is probably corrupted");
17+
call mtr.add_suppression("Stored routine .test...bug14233_[123].: invalid value in column mysql.proc");
1718

1819
# Backup proc table
1920
let $MYSQLD_DATADIR= `select @@datadir`;

0 commit comments

Comments
 (0)