Bug#28897799 BACKPORT TO 5.7: WORKAROUND ASAN BUG FOR TIRPC

This is a backport of:
Bug#28785835 WORKAROUND ASAN BUG FOR TIRPC

Sun RPC, and XDR, is being removed from glibc, and into a separate libtirpc
library. This is not compatible with libasan. The interceptor functions
inserted into the code will segfault.
As a workaround, do LD_PRELOAD=/lib64/libtirpc.so
For dynamically linked libasan (default for gcc), we must preload that as well.

This currently affects fedora, but will likely also affect other linux
variants in the future.

This patch also enables ASAN suppressions in asan.supp
This patch also enables LSAN suppressions in lsan.supp

Change-Id: I1bc777482535ce21595a48ae12679c325667d722
(cherry picked from commit aa9698313b6d412265608fe9f1ffc05938448f81)

Author: Tor Didriksen

mysql-test/asan.supp

@@ -1,3 +1,20 @@
+# Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+
+# ASAN suppressions for gcc/clang
+
 # Warning: this works for clang-3.7 and later
 odr_violation:*yaSSL*
 odr_violation:*TaoCrypt*

mysql-test/lib/My/SafeProcess/CMakeLists.txt

@@ -1,5 +1,5 @@
-# Copyright (c) 2006, 2017, Oracle and/or its affiliates. All rights reserved.
-# 
+# Copyright (c) 2006, 2018, Oracle and/or its affiliates. All rights reserved.
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; version 2 of the License.
@@ -22,13 +22,53 @@ SET(INSTALL_ARGS
   COMPONENT Test
 )
 
+UNSET(HAVE_TIRPC)
+# rpcgen.cmake will store RPC_INCLUDE_DIR in the cache
+IF(RPC_INCLUDE_DIR STREQUAL "/usr/include/tirpc")
+  ADD_DEFINITIONS(-DHAVE_TIRPC)
+  SET(HAVE_TIRPC 1)
+ENDIF()
+
 IF (WIN32)
   MYSQL_ADD_EXECUTABLE(my_safe_process safe_process_win.cc ${INSTALL_ARGS})
   MYSQL_ADD_EXECUTABLE(my_safe_kill safe_kill_win.cc ${INSTALL_ARGS})
 ELSE()
   MYSQL_ADD_EXECUTABLE(my_safe_process safe_process.cc ${INSTALL_ARGS})
 ENDIF()
 
+# Sun RPC, and XDR, is being removed from glibc, and into a separate libtirpc
+# library. This is not compatible with libasan. The interceptor functions
+# inserted into the code will segfault.
+# As a workaround, do LD_PRELOAD=/lib64/libtirpc.so
+# For dynamically linked libasan (default for gcc), we must preload that as well
+IF(HAVE_ASAN AND HAVE_TIRPC)
+  TARGET_INCLUDE_DIRECTORIES(my_safe_process
+    PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
+
+  ADD_CUSTOM_COMMAND(
+    OUTPUT asan_test.c
+    COMMAND ${CMAKE_COMMAND} -E echo "int main() { return 0; }" > asan_test.c
+    VERBATIM
+    )
+  SET_SOURCE_FILES_PROPERTIES(asan_test.c PROPERTIES GENERATED TRUE)
+
+  ADD_EXECUTABLE(asan_test asan_test.c)
+  ADD_CUSTOM_COMMAND(
+    OUTPUT ldd_asan_test_result
+    DEPENDS asan_test
+    COMMAND ldd asan_test > ldd_asan_test_result)
+
+  ADD_CUSTOM_TARGET(extract_asan_library_name
+    DEPENDS ldd_asan_test_result
+    COMMAND ${CMAKE_COMMAND}
+    -DINFILE=${CMAKE_CURRENT_BINARY_DIR}/ldd_asan_test_result
+    -DOUTFILE=${CMAKE_CURRENT_BINARY_DIR}/asan_library_name.h
+    -P ${CMAKE_CURRENT_SOURCE_DIR}/read_ldd_output.cmake
+    )
+
+  ADD_DEPENDENCIES(my_safe_process extract_asan_library_name)
+ENDIF()
+
 INSTALL(TARGETS my_safe_process
   DESTINATION "${INSTALL_MYSQLTESTDIR}/lib/My/SafeProcess" COMPONENT Test
 )

mysql-test/lib/My/SafeProcess/read_ldd_output.cmake

@@ -0,0 +1,31 @@
+# Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+# 
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+
+FILE(READ ${INFILE} LDD_FILE_CONTENTS)
+STRING(REPLACE "\n" ";" LDD_FILE_LINES ${LDD_FILE_CONTENTS})
+
+SET(ASAN_LIBRARY_NAME)
+FOREACH(LINE ${LDD_FILE_LINES})
+  STRING(REGEX MATCH "^[\t ]*(libasan.so.[0-9]) => ([/a-z0-9.]+)" XXX ${LINE})
+  IF(CMAKE_MATCH_1)
+#    MESSAGE(STATUS "LINE ${LINE}")
+#    MESSAGE(STATUS "XXX ${XXX}")
+#    MESSAGE(STATUS "CMAKE_MATCH_1 ${CMAKE_MATCH_1}")
+#    MESSAGE(STATUS "CMAKE_MATCH_2 ${CMAKE_MATCH_2}")
+    SET(ASAN_LIBRARY_NAME ${CMAKE_MATCH_2})
+  ENDIF()
+ENDFOREACH()
+FILE(WRITE ${OUTFILE}
+  "const char *asan_library_name=\"${ASAN_LIBRARY_NAME}\";")

mysql-test/lib/My/SafeProcess/safe_process.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2018, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -54,6 +54,9 @@
 #include <signal.h>
 #include <string.h>
 #include <errno.h>
+#include <string>
+
+#include "my_config.h"
 
 int verbose= 0;
 volatile sig_atomic_t terminated= 0;
@@ -293,6 +296,16 @@ int main(int argc, char* const argv[] )
     // Close write end
     close(pfd[1]);
 
+#if defined(HAVE_ASAN) && defined(HAVE_TIRPC)
+#include "asan_library_name.h"
+    std::string ld_preload = "LD_PRELOAD=";
+    if (strlen(asan_library_name) > 0) {
+      ld_preload.append(asan_library_name);
+      ld_preload.append(":");
+    }
+    ld_preload.append("/lib64/libtirpc.so");
+    putenv(strdup(ld_preload.c_str()));
+#endif
     if (execvp(child_argv[0], child_argv) < 0)
       die("Failed to exec child");
   }

mysql-test/lsan.supp

@@ -0,0 +1,19 @@
+# Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+
+# LSAN suppressions for gcc/clang
+leak:Perl_safesyscalloc
+leak:Perl_safesysmalloc
+leak:Perl_safesysrealloc

mysql-test/mysql-test-run.pl

@@ -2854,7 +2854,9 @@ sub environment_setup {
   $ENV{'VALGRIND_TEST'}= $opt_valgrind;
 
   # Make sure LeakSanitizer exits if leaks are found
-  $ENV{'LSAN_OPTIONS'}= "exitcode=42";
+  $ENV{'LSAN_OPTIONS'} = "exitcode=42,suppressions=${glob_mysql_test_dir}/lsan.supp";
+
+  $ENV{'ASAN_OPTIONS'} = "suppressions=${glob_mysql_test_dir}/asan.supp";
 
   # Add dir of this perl to aid mysqltest in finding perl
   my $perldir= dirname($^X);